Summary: | Update browser alerts to modals: OPAC tags | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | Needs documenting --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This changes the process for removing a tag from a title on a patron's tag list (OPAC > Your account > Tags). It now uses a confirmation dialog box instead of a JavaScript alert. It also makes some minor tweaks to the CSS to correct the style for "Remove tag" links.
|
Version(s) released in: |
24.11.00,24.05.02
|
Circulation function: | |||
Bug Depends on: | 34478, 26824 | ||
Bug Blocks: | 36166, 36557 | ||
Attachments: |
Bug 36207: Use confirmation modal when removing tags from titles in the OPAC
Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Bug 36207: (RM follow-up) CSRF correction |
Description
Owen Leonard
2024-02-29 18:30:37 UTC
Created attachment 163575 [details] [review] Bug 36207: Use confirmation modal when removing tags from titles in the OPAC This patch changes the process of removing a tag from a title on the user's tag list. It now uses a confirmation modal dialog instead of a JavaScript alert. The patch also makes some minor tweaks to CSS to correct style on "remove" links. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who has submitted multiple tags or tags on multiple items. - Open the "Tags" link in the sidebar of the user summary page. - Click the "Remove tag" link next to one of the titles in the table of the user's tags. - You should see a modal confirmation message, "Are you sure you want to remove the selected tag from this title?" It should show the title and the tag which will be removed. - Test both the "Yes, remove tag" and "No, do not remove tag" choices. - Check the box next to one of the tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title and the tag which will be removed. - Test boh the "Yes" and "No" choices. - Check the box next to multiple tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove the selected tags from these titles" It should show the titles of all the records you selected and the corresponding tags to be removed. - Test both the "Yes" and "No" choices. Created attachment 163578 [details] [review] Bug 36207: Use confirmation modal when removing tags from titles in the OPAC This patch changes the process of removing a tag from a title on the user's tag list. It now uses a confirmation modal dialog instead of a JavaScript alert. The patch also makes some minor tweaks to CSS to correct style on "remove" links. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who has submitted multiple tags or tags on multiple items. - Open the "Tags" link in the sidebar of the user summary page. - Click the "Remove tag" link next to one of the titles in the table of the user's tags. - You should see a modal confirmation message, "Are you sure you want to remove the selected tag from this title?" It should show the title and the tag which will be removed. - Test both the "Yes, remove tag" and "No, do not remove tag" choices. - Check the box next to one of the tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title and the tag which will be removed. - Test boh the "Yes" and "No" choices. - Check the box next to multiple tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove the selected tags from these titles" It should show the titles of all the records you selected and the corresponding tags to be removed. - Test both the "Yes" and "No" choices. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> - <form id="deletetags" method="post" action="opac-tags.pl"> - [% INCLUDE 'csrf-token.inc' %] + <form method="post" action="opac-tags.pl"> + <table id="mytagst" class="table table-bordered table-striped"> You remove a CSRF token ? The actual deletion is now being done in a hidden form: <form id="deletetags" name="deletetags" method="post" action="/cgi-bin/koha/opac-tags.pl"> [% INCLUDE 'csrf-token.inc' %] <input type="hidden" name="op" value="cud-del" /> </form> The patch no longer applies (is a dependency for bug 36166): git bz apply 36207 Bug 36207 - Convert browser alerts to modals: OPAC tags 163578 - Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Created attachment 166212 [details] [review] Bug 36207: Use confirmation modal when removing tags from titles in the OPAC This patch changes the process of removing a tag from a title on the user's tag list. It now uses a confirmation modal dialog instead of a JavaScript alert. The patch also makes some minor tweaks to CSS to correct style on "remove" links. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who has submitted multiple tags or tags on multiple items. - Open the "Tags" link in the sidebar of the user summary page. - Click the "Remove tag" link next to one of the titles in the table of the user's tags. - You should see a modal confirmation message, "Are you sure you want to remove the selected tag from this title?" It should show the title and the tag which will be removed. - Test both the "Yes, remove tag" and "No, do not remove tag" choices. - Check the box next to one of the tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title and the tag which will be removed. - Test boh the "Yes" and "No" choices. - Check the box next to multiple tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove the selected tags from these titles" It should show the titles of all the records you selected and the corresponding tags to be removed. - Test both the "Yes" and "No" choices. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 167394 [details] [review] Bug 36207: Use confirmation modal when removing tags from titles in the OPAC This patch changes the process of removing a tag from a title on the user's tag list. It now uses a confirmation modal dialog instead of a JavaScript alert. The patch also makes some minor tweaks to CSS to correct style on "remove" links. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who has submitted multiple tags or tags on multiple items. - Open the "Tags" link in the sidebar of the user summary page. - Click the "Remove tag" link next to one of the titles in the table of the user's tags. - You should see a modal confirmation message, "Are you sure you want to remove the selected tag from this title?" It should show the title and the tag which will be removed. - Test both the "Yes, remove tag" and "No, do not remove tag" choices. - Check the box next to one of the tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title and the tag which will be removed. - Test boh the "Yes" and "No" choices. - Check the box next to multiple tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove the selected tags from these titles" It should show the titles of all the records you selected and the corresponding tags to be removed. - Test both the "Yes" and "No" choices. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice improvement, works as described. Passing QA Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Created attachment 167639 [details] [review] Bug 36207: (RM follow-up) CSRF correction I think there was a rebase issue here where we split the form into two forms instead of one. This patch returns us to one form with two different submit options (one for selected tags and one per tag) that both trigger the confirmation modal before submitting to the controller. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Follow-up confirmed working by Owen and now Pushed by Martin. Backported to 24.05.x for upcoming 24.05.02 Depends on Bug 34478 not in 23.11.x |