Bug 36221

Summary: Improve styling of Standard backend create OPAC form
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Signed Off --- QA Contact: Tomás Cohen Arazi <tomascohen>
Severity: enhancement    
Priority: P5 - low CC: lucas, martin.renvoize, nugged, oleonard, pedro.amorim, tomascohen, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 35725, 36282    
Bug Blocks: 35604    
Attachments: Bug 36221: Preparation
Bug 36221: OPAC Styling
Bug 36221: OPAC Styling
Attachment to Bug 36221 - Improve styling of Standard backend create OPAC form
Bug 36221: Preparation
Bug 36221: OPAC Styling
Bug 36221: Move patron section to top of create form
Bug 36221: Update 'Create' button class
Bug 36221: Preparation
Bug 36221: OPAC Styling
Bug 36221: Move patron section to top of create form
Bug 36221: Update 'Create' button class

Description Pedro Amorim 2024-03-04 14:25:33 UTC

    
Comment 1 Pedro Amorim 2024-03-04 14:27:20 UTC
Created attachment 162715 [details] [review]
Bug 36221: Preparation

This refactors the code for more DRY
Comment 2 Pedro Amorim 2024-03-04 14:27:22 UTC
Created attachment 162716 [details] [review]
Bug 36221: OPAC Styling

Test plan, dont apply patches yet:
1) Enable ILLModule
2) Create a new OPAC ILL request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard
3) Notice the style. Apply patches. Repeat
Comment 3 Lisette Scheer 2024-03-07 23:02:04 UTC
Created attachment 162933 [details] [review]
Bug 36221: OPAC Styling

Test plan, dont apply patches yet:
1) Enable ILLModule
2) Create a new OPAC ILL request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard
3) Notice the style. Apply patches. Repeat

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 4 Lisette Scheer 2024-03-07 23:03:26 UTC
Created attachment 162934 [details] [review]
Attachment to Bug 36221 - Improve styling of Standard backend create OPAC form

Bug 36221: Preparation

This refactors the code for more DRY

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Pedro Amorim 2024-03-08 10:22:10 UTC
Created attachment 162948 [details] [review]
Bug 36221: Preparation

This refactors the code for more DRY

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 6 Pedro Amorim 2024-03-08 10:22:13 UTC
Created attachment 162949 [details] [review]
Bug 36221: OPAC Styling

Test plan, dont apply patches yet:
1) Enable ILLModule
2) Create a new OPAC ILL request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard
3) Notice the style. Apply patches. Repeat

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 7 Pedro Amorim 2024-03-08 10:22:51 UTC
Patches became out of order after Lisette's sign-off and did not apply. It's now fixed.
Comment 8 Pedro Amorim 2024-03-08 15:21:59 UTC
Created attachment 162970 [details] [review]
Bug 36221: Move patron section to top of create form
Comment 9 Pedro Amorim 2024-03-08 15:22:02 UTC
Created attachment 162971 [details] [review]
Bug 36221: Update 'Create' button class

btn-primary should be used here, not btn-default
Comment 10 Pedro Amorim 2024-03-08 15:24:22 UTC
Thank you for looking and sign-off, Lisette!
However I've revisited and added 2 additional patches in case you're available to take a look at those too! Cheers!
Comment 11 Pedro Amorim 2024-04-24 14:22:43 UTC
Created attachment 165462 [details] [review]
Bug 36221: Preparation

This refactors the code for more DRY

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 12 Pedro Amorim 2024-04-24 14:22:46 UTC
Created attachment 165463 [details] [review]
Bug 36221: OPAC Styling

Test plan, dont apply patches yet:
1) Enable ILLModule
2) Create a new OPAC ILL request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard
3) Notice the style. Apply patches. Repeat

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 13 Pedro Amorim 2024-04-24 14:22:51 UTC
Created attachment 165464 [details] [review]
Bug 36221: Move patron section to top of create form
Comment 14 Pedro Amorim 2024-04-24 14:22:53 UTC
Created attachment 165465 [details] [review]
Bug 36221: Update 'Create' button class

btn-primary should be used here, not btn-default