Summary: | koha-run-backups should be first daily job | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Architecture, internals, and plumbing | Assignee: | David Cook <dcook> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the order of the daily cron jobs (/etc/cron.daily/koha-common) so that koha-run-backups is run first.
Reasons for this include:
1. The koha-run-backups cron job takes a backup before running scripts that change database contents. If there is a problem with those scripts, you'll have a very recent backup on which to fallback.
2. It's a resource intensive job. If you have a lot of Koha instances, this means you're running your most intensive job at the end of the job run, which might be a lot later in the day than you anticipate. (Of course, you can update /etc/crontab to change when /etc/cron.daily is run, but this will help reduce impact in the meantime.)
Deployment of this change:
- New installations: This change will seamlessly apply for new installations.
- Existing installations:
. You HAVEN'T manually modified the crontab: it will seamlessly apply.
. You HAVE manually modified the crontab: you will be prompted, and will need to decide about applying the change.
. Where deployment tools are used (such as Ansible): this will depend on what tools you use and how they are configured.
|
Version(s) released in: |
25.05.00
|
Circulation function: | |||
Attachments: |
Bug 36229: Move koha-run-backups to the top of the cron
Bug 36229: Move koha-run-backups to the top of the cron Bug 36229: Move koha-run-backups to the top of the cron |
Description
David Cook
2024-03-05 04:49:59 UTC
Created attachment 176230 [details] [review] Bug 36229: Move koha-run-backups to the top of the cron test plan: 1. check run order of scripts in the cron 2. apply patch 3. koha-run-backups is now at the beginning of the cron Created attachment 176284 [details] [review] Bug 36229: Move koha-run-backups to the top of the cron test plan: 1. check run order of scripts in the cron 2. apply patch 3. koha-run-backups is now at the beginning of the cron Signed-off-by: David Nind <david@davidnind.com> Created attachment 176315 [details] [review] Bug 36229: Move koha-run-backups to the top of the cron test plan: 1. check run order of scripts in the cron 2. apply patch 3. koha-run-backups is now at the beginning of the cron Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! I've added a release note, but a quick question: Will this change only fix this for new installations? If it does, I'll add a note that this change will need to be made manually for existing installations. (In reply to David Nind from comment #5) > I've added a release note, but a quick question: Will this change only fix > this for new installations? > > If it does, I'll add a note that this change will need to be made manually > for existing installations. It's complicated. It will seamlessly apply for new installations, it will seamlessly apply for existing installations where the crontab hasn't been previously manually modified. For existing installations where the crontab has been previously manually modified, sysadmins will be prompted to decide whether or not to apply the change. (Deployment tools like Ansible are often set to automatically accept changes, so automated deployments often will apply the change, but it will vary by individual implementation.) (In reply to David Cook from comment #6) > (In reply to David Nind from comment #5) > > I've added a release note, but a quick question: Will this change only fix > > this for new installations? > > > > If it does, I'll add a note that this change will need to be made manually > > for existing installations. > > It's complicated. > > It will seamlessly apply for new installations, it will seamlessly apply for > existing installations where the crontab hasn't been previously manually > modified. > > For existing installations where the crontab has been previously manually > modified, sysadmins will be prompted to decide whether or not to apply the > change. (Deployment tools like Ansible are often set to automatically accept > changes, so automated deployments often will apply the change, but it will > vary by individual implementation.) Thanks for the great explanation David! I've updated the release note to hopefully reflect this. |