Bug 36256

Summary: Port default MEMBERSHIP_EXPIRY notice to Template Toolkit syntax
Product: Koha Reporter: Emily Lamancusa (emlam) <emily.lamancusa>
Component: NoticesAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: Pushed to main --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, felicie.thiery, klas.blomberg
Version: MainKeywords: Academy, roadmap_24_05
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on:    
Bug Blocks: 15278    
Attachments: Bug 36256: Port default MEMBERSHIP_EXPIRY notice to Template Toolkit syntax
Bug 36256: Port default MEMBERSHIP_EXPIRY notice to Template Toolkit syntax

Description Emily Lamancusa (emlam) 2024-03-06 21:13:25 UTC

    
Comment 1 Caroline Cyr La Rose 2024-12-18 20:27:08 UTC
Created attachment 175675 [details] [review]
Bug 36256: Port default MEMBERSHIP_EXPIRY notice to Template Toolkit syntax

This patch changes the sample MEMBERSHIP_EXPIRY email notice to Template
Toolkit syntax.

To test:
1. Apply patch and reset_all
2. Go to Tools > Notices and slips
3. Check the MEMBERSHIP_EXPIRY email notice, make sure everything looks good (TT syntax, grammar and spelling OK)
4. Add a value in MembershipExpiryDaysNotice
5. Change a patron's account so that it expires in the number of days in MembershipExpiryDaysNotice
6. Add an email address in the patron's account
7. Run /misc/cronjobs/membership_expiry.pl -c
8. Go to the patron's notices and check that the text of the notice was generated correctly and that the grammar and spelling are OK
Comment 2 Felicie 2025-04-02 14:19:30 UTC
Created attachment 180401 [details] [review]
Bug 36256: Port default MEMBERSHIP_EXPIRY notice to Template Toolkit syntax

This patch changes the sample MEMBERSHIP_EXPIRY email notice to Template
Toolkit syntax.

To test:
1. Apply patch and reset_all
2. Go to Tools > Notices and slips
3. Check the MEMBERSHIP_EXPIRY email notice, make sure everything looks good (TT syntax, grammar and spelling OK)
4. Add a value in MembershipExpiryDaysNotice
5. Change a patron's account so that it expires in the number of days in MembershipExpiryDaysNotice
6. Add an email address in the patron's account
7. Run /misc/cronjobs/membership_expiry.pl -c
8. Go to the patron's notices and check that the text of the notice was generated correctly and that the grammar and spelling are OK
Comment 3 Katrin Fischer 2025-05-16 12:27:09 UTC
Pushed for 25.05!

Well done everyone, thank you!