Bug 36268

Summary: Letters.t assumes an empty ReplyToDefault
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Marcel de Rooy <m.de.rooy>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:
Attachments: Bug 36268: Add a mock for ReplyToDefault
Bug 36268: Add a mock for ReplyToDefault

Description Marcel de Rooy 2024-03-07 10:08:56 UTC
We should not assume but mock here.
Comment 1 Marcel de Rooy 2024-03-07 10:49:34 UTC
Created attachment 162895 [details] [review]
Bug 36268: Add a mock for ReplyToDefault

Test plan:
Without this patch, add email address in that pref.
Run Letters.t. It fails.
Now apply patch and run test again. Should pass.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-03-07 10:49:52 UTC
Trivial test change: self SO
Comment 3 Nick Clemens (kidclamp) 2024-04-02 11:39:33 UTC
Created attachment 164261 [details] [review]
Bug 36268: Add a mock for ReplyToDefault

Test plan:
Without this patch, add email address in that pref.
Run Letters.t. It fails.
Now apply patch and run test again. Should pass.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-04-05 09:52:49 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-23 09:51:00 UTC
Pushed to 23.11.x for 23.11.06
Comment 6 Lucas Gass 2024-05-28 17:20:22 UTC
Doesn't apply cleanly to 23.05.x, no backport.