Summary: | SIP2 login broken by CSRF changes | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | SIP2 | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | critical | ||
Priority: | P5 - low | CC: | dcook, fridolin.somers, jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | 36102 | ||
Bug Blocks: | |||
Attachments: |
Bug 36308: Update sip login parameters
Bug 36308: Update sip login parameters Bug 36308: Update sip login parameters |
Description
Nick Clemens (kidclamp)
2024-03-13 17:50:35 UTC
Created attachment 163117 [details] [review] Bug 36308: Update sip login parameters To test: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login fails Apply patch, restart all perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login succeeds Probably we also need test coverage for this login Created attachment 163123 [details] [review] Bug 36308: Update sip login parameters To test: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login fails Apply patch, restart all perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login succeeds Signed-off-by: David Nind <david@davidnind.com> That api_auth() function... yikes. One day we'll do better at AuthN and AuthZ... This looks like an easy win. I'll look at QAing it a bit later this morning... Looking here Created attachment 163161 [details] [review] Bug 36308: Update sip login parameters To test: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login fails Apply patch, restart all perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login succeeds Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! |