Bug 36311

Summary: Add option to koha-run-backups, to only include database dump
Product: Koha Reporter: Danyon Sewell <danyonsewell>
Component: Command-line UtilitiesAssignee: Danyon Sewell <danyonsewell>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: kyle, robin
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36325
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 36311: Add option to koha-run-backups, to only include database dump
Bug 36311: Add option to koha-run-backups, to only include database dump
Bug 36311: Add option to koha-run-backups, to only include database dump

Description Danyon Sewell 2024-03-14 01:23:54 UTC
Adding an additional flag to koha-run-backups when used to exclude everything except the .sql.gz DB dump from koha-dump.
Comment 1 Danyon Sewell 2024-03-14 02:13:57 UTC
Created attachment 163125 [details] [review]
Bug 36311: Add option to koha-run-backups, to only include database dump

Test plan:

1. Dry run koha-run-backups, to verify that both the .sql.gz and .tar.gz backups are included
2. Apply this patch
3. Run the script again, this time with the --schema-only flag
4. check /var/spool/koha/kohadev/ to see that only .sql.gz file has been included.
Comment 2 Danyon Sewell 2024-03-14 03:29:18 UTC
Created attachment 163126 [details] [review]
Bug 36311: Add option to koha-run-backups, to only include database dump

Updated patch logic to work better and zip up the database files and actually include table data instead of just the schema.

Test plan:

1. Dry run koha-run-backups, to verify that both the .sql.gz and .tar.gz backups are included
2. Apply this patch
3. Run the script again, this time with the --db-only-zip flag
4. check /var/spool/koha/kohadev/ to see that only .sql.gz file has been included.
Comment 3 David Nind 2024-03-23 08:17:21 UTC
Created attachment 163755 [details] [review]
Bug 36311: Add option to koha-run-backups, to only include database dump

Updated patch logic to work better and zip up the database files and actually include table data instead of just the schema.

Test plan:

1. Dry run koha-run-backups, to verify that both the .sql.gz and .tar.gz backups are included
2. Apply this patch
3. Run the script again, this time with the --db-only-zip flag
4. check /var/spool/koha/kohadev/ to see that only .sql.gz file has been included.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Kyle M Hall (khall) 2024-05-10 15:43:42 UTC
I don't think "Dump only the database and also zip the file" clearly communicates what this option does. Can you update the language to clarify that?
Comment 5 Danyon Sewell 2024-09-19 01:40:34 UTC
(In reply to Kyle M Hall from comment #4)
> I don't think "Dump only the database and also zip the file" clearly
> communicates what this option does. Can you update the language to clarify
> that?

Hi Kyle.

Could you please clarify what you mean by this? Do you mean for us to specify in the language that the database dump is the file being zipped up? Or are you referring to something else?

Cheers,
Danyon