Summary: | koha_perl_deps.pl can be run from the UI | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, dcook, didier.gautheron, fridolin.somers, jonathan.druart, laurent.ducos, lucas, m.de.rooy, martin.renvoize, nick, tomascohen, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36322 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36348 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24879 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04,23.05.10,22.11.16,22.05.20
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36348, 36999 | ||
Attachments: |
Bug 36323: Move koha_perl_deps.pl to misc/devel
Bug 36323: Move koha_perl_deps.pl to misc/devel Bug 36323: Move koha_perl_deps.pl to misc/devel |
Description
Jonathan Druart
2024-03-14 15:51:33 UTC
It's a dev/sysadmin only script I believe, so it would only run in a git install - not a tarball or package install. If you were doing a tarball install, you could run it on your system before trying to install to figure out what Perl dependencies you're missing. This relates to the problem we have with our codebase of having our web scripts at the top-level of the directory (instead of somewhere like a "src" or "public" directory). Changing that is an argument I've had on and off for years though heh. Yes, just noticed it was not copied in Makefile.PL. So I guess it's not a problem. I'd be onboard with a shift to /public, /src or /web for all our controller scripts. We did start down that road on bug 9949.. I think you had some alternative options David, but likely time got the better of you. This is an issue for dev installs I propose we move it to misc/devel Created attachment 163341 [details] [review] Bug 36323: Move koha_perl_deps.pl to misc/devel And remove from t/db_dependent/00-strict.t ? I found those pages to fix : https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_git https://wiki.koha-community.org/wiki/Install_and_Setup_Koha_to_use_Git_on_a_Development_Server No need to fix pages related to old Koha version 3.x Created attachment 163423 [details] [review] Bug 36323: Move koha_perl_deps.pl to misc/devel Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This seems very sensible to me.. Signing off. Created attachment 163466 [details] [review] Bug 36323: Move koha_perl_deps.pl to misc/devel Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master-security. Backported to 22.05.x-security for 22.05.20 Looks like with this there is no need for koha_perl_deps.pl to be in xt/find-missing-auth_checks.t ? See patch Bug 24879: Exclude koha_perl_deps.pl (In reply to Fridolin Somers from comment #15) > Looks like with this there is no need for koha_perl_deps.pl to be in > xt/find-missing-auth_checks.t ? > See patch > Bug 24879: Exclude koha_perl_deps.pl Bah it has been released to lets forget ;) New warning on Jenkins Koha_Master_U20/1162 koha_1 | Can't stat koha_perl_deps.pl: No such file or directory koha_1 | at /usr/share/perl5/Test/Strict.pm line 151. I guess it's coming from t/db_dependent/00-strict.t (In reply to Jonathan Druart from comment #17) > New warning on Jenkins Koha_Master_U20/1162 > > koha_1 | Can't stat koha_perl_deps.pl: No such file or directory > koha_1 | at /usr/share/perl5/Test/Strict.pm line 151. > > I guess it's coming from t/db_dependent/00-strict.t ping Fridolin, this is still valid! OK created Bug 36999 Removed additional work needed keyword - addressed by bug 36999. No changes required to the manual. Changed status from "Pushed to oldoldoldstable" to "Resolved Fixed". |