Description
Tomás Cohen Arazi (tcohen)
2024-03-15 11:15:26 UTC
Created attachment 163232 [details] [review] Bug 36329: Add missing return codes Created attachment 163233 [details] [review] Bug 36329: Miscelaneous spec fixes Created attachment 163234 [details] [review] Bug 36329: Make POST /transfer_limits/batch honor BranchTransferLimitsType This patch adds tests for the different cases of `BranchTransferLimitsType`. It also adds tests for the situation of the consumer sending both limit criterias on the request. The controller gets adjusted for this new behavior and the spec gets documentation added about this. Bonus: tests are added the right guidelines code, and BranchTransferLimitsType gets mocked to avoid failures due to existing data. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ qa => SUCCESS: All green, and tests pass! 3. Sign off :-D Created attachment 163280 [details] [review] Bug 36329: Add missing return codes Signed-off-by: David Nind <david@davidnind.com> Created attachment 163281 [details] [review] Bug 36329: Miscelaneous spec fixes Signed-off-by: David Nind <david@davidnind.com> Created attachment 163282 [details] [review] Bug 36329: Make POST /transfer_limits/batch honor BranchTransferLimitsType This patch adds tests for the different cases of `BranchTransferLimitsType`. It also adds tests for the situation of the consumer sending both limit criterias on the request. The controller gets adjusted for this new behavior and the spec gets documentation added about this. Bonus: tests are added the right guidelines code, and BranchTransferLimitsType gets mocked to avoid failures due to existing data. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ qa => SUCCESS: All green, and tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Tests pass before and after the patches are applied: prove t/db_dependent/api/v1/transfer_limits.t Created attachment 163365 [details] [review] Bug 36329: Add missing return codes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 163366 [details] [review] Bug 36329: Miscelaneous spec fixes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 163367 [details] [review] Bug 36329: Make POST /transfer_limits/batch honor BranchTransferLimitsType This patch adds tests for the different cases of `BranchTransferLimitsType`. It also adds tests for the situation of the consumer sending both limit criterias on the request. The controller gets adjusted for this new behavior and the spec gets documentation added about this. Bonus: tests are added the right guidelines code, and BranchTransferLimitsType gets mocked to avoid failures due to existing data. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ qa => SUCCESS: All green, and tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Created attachment 163453 [details] [review] Bug 36329: (follow-up) Fix error message comparisson in testes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed the follow-up. Pushed to 23.11.x for 23.11.04 Backported to 23.05.x for upcoming 23.05.12 |