| Summary: | CheckReserves sometimes lead to bad behavior | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
| Component: | Circulation | Assignee: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Bug 36346 : Prevent moving to the next object on 'not_allowed' rule | ||
|
Description
Thibaud Guillot (thibaud_g)
2024-03-18 14:57:47 UTC
Created attachment 163339 [details] [review] Bug 36346 : Prevent moving to the next object on 'not_allowed' rule Test plan: 1) Enable AllowHoldPolicyOverride 2) Set a new circulation rule on "Default holds policy by item type": For example, an item type called "Comics" with Hold policy set on "No holds allowed" 3) Go to an item related to this item type and force a hold :) 4) Try to perform a check-in on this item, no pop up 5) Try to perform a check out for another patron, no pop up again 6) Apply this patch 7) Repeat step 4 and 4, normally now there is a pop up with hold information Sponsored by : BibLibre I am not sure this is a bug - librarians sometimes want to be able to force a hold that will only fill later - for example a book on the display shelves might not fill holds, but it can fill holds after it moves, and they could use an itemtype for this control - new books are a similar example I was thinking that if we have the possibility of forcing a hold even if it is not authorized in the rules, the hold should still be found if it exists in certain cases (those I list in the test plan). I think this would just fix one case of forced holds, but the problem is a wider one. There are some bugs around this that could be interesting to have a look at. Entry point is: Bug 31169 - [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride) I think Nick is right in that some libraries expect this behavior, but it would be nice if we could work out a way that we can make this a bit more flexible for libraries which would like things to work differently. But as it is with holds, things tend to be complex :) |