Summary: | Return claims table is loaded twice | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Circulation | Assignee: | Julian Maurice <julian.maurice> |
Status: | Pushed to oldstable --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, kyle.m.hall, lucas, pierre.genty |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
Circulation function: | |||
Attachments: |
Bug 36347: Avoid return claims table being loaded twice
Bug 36347: Avoid return claims table being loaded twice Bug 36347: Avoid return claims table being loaded twice |
Description
Julian Maurice
2024-03-18 15:09:11 UTC
Created attachment 163340 [details] [review] Bug 36347: Avoid return claims table being loaded twice The issue is caused by these lines in circulation.js: $("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){ $(this).click(); }); When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and then another click event is triggered. And because the table was loaded on tab click, it was loaded twice. Visually it could have caused the rows to be duplicated (it was random, probably due to timing, network latency, ...) I don't know why we need to trigger a click in this case, but removing this will probably break something else, so the fix here is to load the table on 'shown.bs.tab' event instead of 'click' This patch also contains a small fix in refreshReturnClaimsTable which was reloading the table right after the table initialization. Test plan: 1. Check out an item, and in the checkouts table, click "Claim returned" 2. Open the network tab of your browser's developer tools 3. Click on the "Claims" tab, verify that only one call is made to svc/return_claims 4. Verify that the claims table is displayed correctly Created attachment 163747 [details] [review] Bug 36347: Avoid return claims table being loaded twice The issue is caused by these lines in circulation.js: $("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){ $(this).click(); }); When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and then another click event is triggered. And because the table was loaded on tab click, it was loaded twice. Visually it could have caused the rows to be duplicated (it was random, probably due to timing, network latency, ...) I don't know why we need to trigger a click in this case, but removing this will probably break something else, so the fix here is to load the table on 'shown.bs.tab' event instead of 'click' This patch also contains a small fix in refreshReturnClaimsTable which was reloading the table right after the table initialization. Test plan: 1. Check out an item, and in the checkouts table, click "Claim returned" 2. Open the network tab of your browser's developer tools 3. Click on the "Claims" tab, verify that only one call is made to svc/return_claims 4. Verify that the claims table is displayed correctly Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. I had to play with the browser developer tools in the network section to display the right information: . Firefox: right-click on the columns > Reset Columns + display the URL column . Chromium: reset columns shown, information shows in the Path column 2. Before the patch, there were three requests shown for me. Changes make sense, works as intended, QA scripts are happy. Created attachment 163849 [details] [review] Bug 36347: Avoid return claims table being loaded twice The issue is caused by these lines in circulation.js: $("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){ $(this).click(); }); When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and then another click event is triggered. And because the table was loaded on tab click, it was loaded twice. Visually it could have caused the rows to be duplicated (it was random, probably due to timing, network latency, ...) I don't know why we need to trigger a click in this case, but removing this will probably break something else, so the fix here is to load the table on 'shown.bs.tab' event instead of 'click' This patch also contains a small fix in refreshReturnClaimsTable which was reloading the table right after the table initialization. Test plan: 1. Check out an item, and in the checkouts table, click "Claim returned" 2. Open the network tab of your browser's developer tools 3. Click on the "Claims" tab, verify that only one call is made to svc/return_claims 4. Verify that the claims table is displayed correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |