|
Description
Katrin Fischer
2024-03-19 16:31:43 UTC
Created attachment 187984 [details] [review] Bug 36360: Add Illrequest to list of stuff to consider merging Created attachment 187985 [details] [review] Bug 36360: Add tests prove t/db_dependent/Koha/Patrons.t Test plan, k-t-d: 1) Enable ILLModule 2) Create an ILL request for patron 'John', visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Type 'John' and pick the only result. Set a type and library. Click 'Create'. 4) Go to patrons search and search for 'jo': <staff_url>/cgi-bin/koha/members/members-home.pl 5) Tick the checkbox for John and someone else from the list. Click 'Merge selected patrons' from the top toolbar 6) Select the other patron (not John) as the 'patron to keep'. Click Merge patrons. 7) Notice '1 Illrequest was merge' message shows. 8) Visit the ILL list table, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 9) Notice the ILL request now belongs to the other patron, not John (who no longer exists). Created attachment 189922 [details] [review] Bug 36360: Add Illrequest to list of stuff to consider merging Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Created attachment 189923 [details] [review] Bug 36360: Add tests prove t/db_dependent/Koha/Patrons.t Test plan, k-t-d: 1) Enable ILLModule 2) Create an ILL request for patron 'John', visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Type 'John' and pick the only result. Set a type and library. Click 'Create'. 4) Go to patrons search and search for 'jo': <staff_url>/cgi-bin/koha/members/members-home.pl 5) Tick the checkbox for John and someone else from the list. Click 'Merge selected patrons' from the top toolbar 6) Select the other patron (not John) as the 'patron to keep'. Click Merge patrons. 7) Notice '1 Illrequest was merge' message shows. 8) Visit the ILL list table, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 9) Notice the ILL request now belongs to the other patron, not John (who no longer exists). Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Created attachment 192247 [details] [review] Bug 36360: Add Illrequest to list of stuff to consider merging Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 192248 [details] [review] Bug 36360: Add tests prove t/db_dependent/Koha/Patrons.t Test plan, k-t-d: 1) Enable ILLModule 2) Create an ILL request for patron 'John', visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Type 'John' and pick the only result. Set a type and library. Click 'Create'. 4) Go to patrons search and search for 'jo': <staff_url>/cgi-bin/koha/members/members-home.pl 5) Tick the checkbox for John and someone else from the list. Click 'Merge selected patrons' from the top toolbar 6) Select the other patron (not John) as the 'patron to keep'. Click Merge patrons. 7) Notice '1 Illrequest was merge' message shows. 8) Visit the ILL list table, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 9) Notice the ILL request now belongs to the other patron, not John (who no longer exists). Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Nice work everyone! Pushed to main for 26.05 |