Summary: | Authorities search is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
Component: | Architecture, internals, and plumbing | Assignee: | Phil Ringnalda <phil> |
Status: | CLOSED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, julian.maurice, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36192 | ||
Attachments: |
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search |
Description
Emily Lamancusa (emlam)
2024-03-20 21:10:58 UTC
authorities/auth_finder.pl thinks the op is cud-do_search; koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc thinks the op is do_search and is correct, since the method is GET. Created attachment 164442 [details] [review] Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search The authority finder just does a GET for a list of search results, it doesn't create or update or delete, so the template that thinks the op is do_search is correct. Test plan: 1. Cataloging - New record 2. In the 1 tab click the Tag editor icon at the end of 100 subfield a 3. In the popup, click Search, and nothing happens, no results are shown. 4. Apply patch, reset_all 5. Repeat steps 1-3, see that you get results. Created attachment 164464 [details] [review] Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search The authority finder just does a GET for a list of search results, it doesn't create or update or delete, so the template that thinks the op is do_search is correct. Test plan: 1. Cataloging - New record 2. In the 1 tab click the Tag editor icon at the end of 100 subfield a 3. In the popup, click Search, and nothing happens, no results are shown. 4. Apply patch, reset_all 5. Repeat steps 1-3, see that you get results. Signed-off-by: David Nind <david@davidnind.com> Created attachment 164494 [details] [review] Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search The authority finder just does a GET for a list of search results, it doesn't create or update or delete, so the template that thinks the op is do_search is correct. Test plan: 1. Cataloging - New record 2. In the 1 tab click the Tag editor icon at the end of 100 subfield a 3. In the popup, click Search, and nothing happens, no results are shown. 4. Apply patch, reset_all 5. Repeat steps 1-3, see that you get results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Works as described, passes QA tests Pushed for 24.05! Well done everyone, thank you! |