Summary: | Prevent Net::Server warn about User Not Defined from SIPServer | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | Pushed to oldstable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, kyle, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
Circulation function: | |||
Attachments: |
Bug 36386: Pass user and group to Net::Server
Bug 36386: Pass user and group to Net::Server Bug 36386: Pass user and group to Net::Server |
Description
Marcel de Rooy
2024-03-21 14:16:45 UTC
Created attachment 163616 [details] [review] Bug 36386: Pass user and group to Net::Server This prevents the User/Group Not Defined warns in syslog. Test plan: Restart sip and check your syslog. Not sure how to replicate using koha-testing-docker (KTD). There is no /var/log/syslog There is also nothing in the journal log (sudo journalctl or sudo journalctl -u syslog). In addition, those warnings don't appear in /var/log/koha/kohadev/sip.log (after restarting sip with sudo koha-sip --restart kohadev or a restart_all). The default KTD is using Debian 11 (bullseye) (cat /etc/os-release). Tomas, do you know if this warning ends up somewhere else in KTD instead of syslog? Created attachment 163902 [details] [review] Bug 36386: Pass user and group to Net::Server This prevents the User/Group Not Defined warns in syslog. Test plan: Restart sip and check your syslog. KTD Test Plan: 1) Stop your SIP server 2) Run "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/koha-conf.xml" We need valid XML without any valid SIP settings to the output goes to the command line 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) No warnings! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 165028 [details] [review] Bug 36386: Pass user and group to Net::Server This prevents the User/Group Not Defined warns in syslog. Test plan: Restart sip and check your syslog. KTD Test Plan: 1) Stop your SIP server 2) Run "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/koha-conf.xml" We need valid XML without any valid SIP settings to the output goes to the command line 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) No warnings! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice bit of cleanup.. Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |