Summary: | Only 20 vendors in ERM dropdown | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | ERM | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to oldstable --- | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, jonathan.field, lucas, matt.blenkinsop, matthias.le-gac, pedro.amorim, philippe.blouin |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the listing of vendors when adding a new agreement in the electronic resources (ERM) module. Previously only the first 20 vendors were displayed, now all vendors are displayed.
|
Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
Circulation function: | |||
Bug Depends on: | 32468, 34219 | ||
Bug Blocks: | |||
Attachments: |
Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM
Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM |
Description
Caroline Cyr La Rose
2024-03-21 19:55:49 UTC
I bisected and found that it was due to bug 34219 which was added to 23.05.04 which makes sense because my client's 23.05.05 has the wrong behaviour. Created attachment 163660 [details] [review] Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors Created attachment 163671 [details] [review] Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors Signed-off-by: David Nind <david@davidnind.com> I applied the patch to master, checking that I was up to date. I checked that the code had changed. Then I created more than 20 suppliers and when I go to E-resource management > Agreements > New agreement and click on the vendor dropdown. I still only get 20 results. If I change the RESTdefaultPageSize preference as Caroline says, then I can see all the vendors. Did I miss a step because I see that David signed Off? Hi Matthias. A 'yarn build' is required after applying the patch for view-related changes (and I normally do a flush_memcached and restart_all) (this was using koha-testing-docker). David Created attachment 163741 [details] [review] Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matthias Le Gac <matthias.le-gac@inlibro.com> Thanks after I yarn build and reload apache2 all works good. Created attachment 163775 [details] [review] Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matthias Le Gac <matthias.le-gac@inlibro.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |