| Summary: | Useless fetch of AV categories in admin/marc_subfields_structure.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, michaela.sieber, wainuiwitikapark |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
| Circulation function: | |||
| Bug Depends on: | 17216 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl
Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl |
||
Created attachment 163679 [details] [review] Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl Since (a long time ago!) commit 62aa3f4292d83bc9304e296de5f0830e28510492 Bug 17216: Use Koha::AVC from mss.pl This $sth2 is never fetched, we are retrieving the AV cat using Koha::AV::Categories Sponsored-by: The Research University in the Helmholtz Association (KIT) Created attachment 163726 [details] [review] Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl Since (a long time ago!) commit 62aa3f4292d83bc9304e296de5f0830e28510492 Bug 17216: Use Koha::AVC from mss.pl This $sth2 is never fetched, we are retrieving the AV cat using Koha::AV::Categories Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 164200 [details] [review] Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl Since (a long time ago!) commit 62aa3f4292d83bc9304e296de5f0830e28510492 Bug 17216: Use Koha::AVC from mss.pl This $sth2 is never fetched, we are retrieving the AV cat using Koha::AV::Categories Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 Not backporting to 22.11 |
# build authorised value list $sth2->finish; $sth2 = $dbh->prepare("select distinct category from authorised_values"); $sth2->execute; my @authorised_values= Koha::AuthorisedValueCategories->search->get_column('category_name'); $sth2 is never fetched.