Bug 36439

Summary: Column settings are missing on holds-to-pull table
Product: Koha Reporter: Andreas Jonsson <andreas.jonsson>
Component: Hold requestsAssignee: Andreas Jonsson <andreas.jonsson>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P3 CC: fridolin.somers, gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Bug Depends on: 33575    
Bug Blocks:    
Attachments: Bug 36439: Remove duplicate section in columns_settings
Bug 36439: Remove duplicate section in columns_settings
Bug 36439: Remove duplicate section in columns_settings

Description Andreas Jonsson 2024-03-27 14:14:20 UTC
The column settings (the cog wheel icon) are missing on the table on the pending reserves page due to an ill applied patch for bug 33575.
Comment 1 Andreas Jonsson 2024-03-27 14:30:28 UTC
Created attachment 164007 [details] [review]
Bug 36439: Remove duplicate section in columns_settings

   The patch for bug 33575 was carelessely applied so
   the holds section was overwritten by a duplicated
   section which cause the table configuration for
   the holds-to-pull table to be missing.

   Test plan:

   * Place a hold on a record that has items (so there is at least one hold to pull)
   * Go to the page "holds to pull" and verify that the column settings are present
     to the left above the table (<cog wheel icon> Columns).

     NOTE: the column settings are cached, so you need to reset memcached
     between tests if you want to test with and without the patch.
Comment 2 Lucas Gass 2024-03-27 17:53:32 UTC
Created attachment 164021 [details] [review]
Bug 36439: Remove duplicate section in columns_settings

The patch for bug 33575 was carelessely applied so
   the holds section was overwritten by a duplicated
   section which cause the table configuration for
   the holds-to-pull table to be missing.

   Test plan:

   * Place a hold on a record that has items (so there is at least one hold to pull)
   * Go to the page "holds to pull" and verify that the column settings are present
     to the left above the table (<cog wheel icon> Columns).

     NOTE: the column settings are cached, so you need to reset memcached
     between tests if you want to test with and without the patch.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Nick Clemens (kidclamp) 2024-03-30 14:54:46 UTC
Created attachment 164158 [details] [review]
Bug 36439: Remove duplicate section in columns_settings

The patch for bug 33575 was carelessely applied so
   the holds section was overwritten by a duplicated
   section which cause the table configuration for
   the holds-to-pull table to be missing.

   Test plan:

   * Place a hold on a record that has items (so there is at least one hold to pull)
   * Go to the page "holds to pull" and verify that the column settings are present
     to the left above the table (<cog wheel icon> Columns).

     NOTE: the column settings are cached, so you need to reset memcached
     between tests if you want to test with and without the patch.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-04-05 09:53:07 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-23 11:48:53 UTC
Pushed to 23.11.x for 23.11.06
Comment 6 Lucas Gass 2024-05-28 17:25:53 UTC
Not needed in 23.05.x