Summary: | Column settings are missing on holds-to-pull table | ||
---|---|---|---|
Product: | Koha | Reporter: | Andreas Jonsson <andreas.jonsson> |
Component: | Hold requests | Assignee: | Andreas Jonsson <andreas.jonsson> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P3 | CC: | fridolin.somers, gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
Circulation function: | |||
Bug Depends on: | 33575 | ||
Bug Blocks: | |||
Attachments: |
Bug 36439: Remove duplicate section in columns_settings
Bug 36439: Remove duplicate section in columns_settings Bug 36439: Remove duplicate section in columns_settings |
Description
Andreas Jonsson
2024-03-27 14:14:20 UTC
Created attachment 164007 [details] [review] Bug 36439: Remove duplicate section in columns_settings The patch for bug 33575 was carelessely applied so the holds section was overwritten by a duplicated section which cause the table configuration for the holds-to-pull table to be missing. Test plan: * Place a hold on a record that has items (so there is at least one hold to pull) * Go to the page "holds to pull" and verify that the column settings are present to the left above the table (<cog wheel icon> Columns). NOTE: the column settings are cached, so you need to reset memcached between tests if you want to test with and without the patch. Created attachment 164021 [details] [review] Bug 36439: Remove duplicate section in columns_settings The patch for bug 33575 was carelessely applied so the holds section was overwritten by a duplicated section which cause the table configuration for the holds-to-pull table to be missing. Test plan: * Place a hold on a record that has items (so there is at least one hold to pull) * Go to the page "holds to pull" and verify that the column settings are present to the left above the table (<cog wheel icon> Columns). NOTE: the column settings are cached, so you need to reset memcached between tests if you want to test with and without the patch. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 164158 [details] [review] Bug 36439: Remove duplicate section in columns_settings The patch for bug 33575 was carelessely applied so the holds section was overwritten by a duplicated section which cause the table configuration for the holds-to-pull table to be missing. Test plan: * Place a hold on a record that has items (so there is at least one hold to pull) * Go to the page "holds to pull" and verify that the column settings are present to the left above the table (<cog wheel icon> Columns). NOTE: the column settings are cached, so you need to reset memcached between tests if you want to test with and without the patch. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Not needed in 23.05.x |