| Summary: | Advanced editor should disable RequireJS timeout with waitSeconds: 0 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Phil Ringnalda <phil> |
| Component: | Cataloging | Assignee: | Phil Ringnalda <phil> |
| Status: | Pushed to oldoldstable --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0
Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 |
||
|
Description
Phil Ringnalda
2024-03-28 22:57:45 UTC
Created attachment 164099 [details] [review] Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. Created attachment 164125 [details] [review] Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial update - we aren't handling the error, so waiting will appear the same, but it may succeed now Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |