Summary: | We should compress our JSON responses (gzip deflate mod_deflate application/json) | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Pushed to oldstable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart, julian.maurice, lucas, m.de.rooy, phil, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36531 | ||
Attachments: |
Bug 36463: Compress application/json
Bug 36463: Compress application/json Bug 36463: (follow-up) Adjust other occurence (intranet) Bug 36463: (follow-up) Adjust other occurence (intranet) Bug 36463: Compress application/json Bug 36463: (follow-up) Adjust other occurence (intranet) |
Description
Nick Clemens (kidclamp)
2024-03-29 12:54:12 UTC
Created attachment 164128 [details] [review] Bug 36463: Compress application/json This patch simply adds application/json to the mod_deflate configuration To test: 1 - Open the netowrk tab in firefox 2 - Load http://localhost:8081/api/v1/libraries 3 - Not the transferred size, and note no 'Content-Encoding: gzip" header 4 - Apply patch, reset_all (or edit /etc/koha/apache-shared.conf) 5 - Reload 6 - Note smaller size, note gzip header Created attachment 164137 [details] [review] Bug 36463: Compress application/json This patch simply adds application/json to the mod_deflate configuration To test: 1 - Open the netowrk tab in firefox 2 - Load http://localhost:8081/api/v1/libraries 3 - Not the transferred size, and note no 'Content-Encoding: gzip" header 4 - Apply patch, reset_all (or edit /etc/koha/apache-shared.conf) 5 - Reload 6 - Note smaller size, note gzip header Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> In etc/koha-httpd.conf, they are two mod_deflate.c section. Your patch modify the 1st one, not the 2nd one. Isn't it necessary? Created attachment 164138 [details] [review] Bug 36463: (follow-up) Adjust other occurence (intranet) Created attachment 164139 [details] [review] Bug 36463: (follow-up) Adjust other occurence (intranet) Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 164496 [details] [review] Bug 36463: Compress application/json This patch simply adds application/json to the mod_deflate configuration To test: 1 - Open the netowrk tab in firefox 2 - Load http://localhost:8081/api/v1/libraries 3 - Not the transferred size, and note no 'Content-Encoding: gzip" header 4 - Apply patch, reset_all (or edit /etc/koha/apache-shared.conf) 5 - Reload 6 - Note smaller size, note gzip header Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 164497 [details] [review] Bug 36463: (follow-up) Adjust other occurence (intranet) Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice improvement.. works and is clean Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |