| Summary: | Some scripts missing a dependency following Bug 24879 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Isabel Pineda <isabel.pineda> |
| Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to oldoldoldstable --- | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | boris.dovbnya, dcook, fridolin.somers, hansulrich.frink, jonathan.druart, lucas, m.de.rooy, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04,23.05.10,22.11.16,22.05.20
|
|
| Circulation function: | |||
| Bug Depends on: | 24879 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36511: Some scripts missing a dependency following Bug 24879
Bug 36511: Some scripts missing a dependency following Bug 24879 Bug 36511: Some scripts missing a dependency following Bug 24879 |
||
|
Description
Isabel Pineda
2024-04-03 22:02:51 UTC
My problem is described exactly here (Bug 36511). A speedy correction would be greatly appreciated. I'm waiting for help. The error I get is: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_catalogue_image_2epl::check_cookie_auth called at /kohadevbox/koha/catalogue/image.pl line 36 Created attachment 164566 [details] [review] Bug 36511: Some scripts missing a dependency following Bug 24879 These files needed the addition of 'use C4::Auth qw( check_cookie_auth );'. To test, apply the patch and restart services. - If necessary, enable the LocalCoverImages system preference. - Open the browser console and then the "Network" tab. You can click "Images" to filter for the correct kind of request. - Perform a catalog search. After the search has loaded, check that there are no 500 errors in the Network tab. - Go to Cataloging -> Label creator. - If necessary, create a label batch and add some items. - Export your batch and test both the "Download as CSV" and "Download as XML" links. Both should trigger the correct download. - Go to Serials -> Claims, and select a vendor with late issues. - Select all late issues and click "Download selected claims" at the bottom of the page. - Your CSV file should download correctly. The file acqui/check_uniqueness.pl has been corrected as well but I'm not sure how to test it! Created attachment 164574 [details] [review] Bug 36511: Some scripts missing a dependency following Bug 24879 These files needed the addition of 'use C4::Auth qw( check_cookie_auth );'. To test, apply the patch and restart services. - If necessary, enable the LocalCoverImages system preference. - Open the browser console and then the "Network" tab. You can click "Images" to filter for the correct kind of request. - Perform a catalog search. After the search has loaded, check that there are no 500 errors in the Network tab. - Go to Cataloging -> Label creator. - If necessary, create a label batch and add some items. - Export your batch and test both the "Download as CSV" and "Download as XML" links. Both should trigger the correct download. - Go to Serials -> Claims, and select a vendor with late issues. - Select all late issues and click "Download selected claims" at the bottom of the page. - Your CSV file should download correctly. The file acqui/check_uniqueness.pl has been corrected as well but I'm not sure how to test it! Signed-off-by: danyonsewell <danyonsewell@catalyst.net.nz> Created attachment 164577 [details] [review] Bug 36511: Some scripts missing a dependency following Bug 24879 These files needed the addition of 'use C4::Auth qw( check_cookie_auth );'. To test, apply the patch and restart services. - If necessary, enable the LocalCoverImages system preference. - Open the browser console and then the "Network" tab. You can click "Images" to filter for the correct kind of request. - Perform a catalog search. After the search has loaded, check that there are no 500 errors in the Network tab. - Go to Cataloging -> Label creator. - If necessary, create a label batch and add some items. - Export your batch and test both the "Download as CSV" and "Download as XML" links. Both should trigger the correct download. - Go to Serials -> Claims, and select a vendor with late issues. - Select all late issues and click "Download selected claims" at the bottom of the page. - Your CSV file should download correctly. The file acqui/check_uniqueness.pl has been corrected as well but I'm not sure how to test it! Signed-off-by: danyonsewell <danyonsewell@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.05! Well done everyone, thank you! We just bumped into this as well for 23.11.04. Will need to backport this one pretty widely. Our koha install is showing this error, too. I patched image.pl with the additional line. The error persisted: in admin page no local cover images are shown. GET https://gagldkohastaff.duckdns.org/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=1243 500 (Internal Server Error) Do I have to apply the patch to all 5 files? thanks Uli Pushed to 23.11.x on top of v23.11.04 Pushed to 23.05.10 and packaged for 23.05.10-02 Pushed to 22.05.x for 22.05.20-3 (In reply to wainuiwitikapark from comment #12) > Pushed to 22.05.x for 22.05.20-3 *v22.05.20-2 I see it in in 22.11.16 |