| Summary: | Fix output from install_plugins.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> | 
| Component: | Command-line Utilities | Assignee: | Magnus Enger <magnus> | 
| Status: | RESOLVED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> | 
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | dcook, emily.lamancusa, fridolin.somers, lucas, robin, wainuiwitikapark | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       24.05.00,23.11.06,23.05.12 
 | 
        
        Circulation function: | |
| Attachments: | 
              Bug 36517: Fix output from install_plugins.pl
               Bug 36517: Fix output from install_plugins.pl Bug 36517: Fix output from install_plugins.pl  | 
      ||
| 
 
        
          Description
        
        
          Magnus Enger
        
        
        
        
          2024-04-04 09:23:09 UTC
        
       
    Sorry, this is what running the script will look like: $ perl misc/devel/install_plugins.pl No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha$ Created attachment 164477 [details] [review] Bug 36517: Fix output from install_plugins.pl When misc/devel/install_plugins.pl does not find any plugins, it prints the list of pluginsdir, but with a literal \n separating the dirs, and no newline at the end. To test: - Edit koha-conf.xml and add a second entry for <pluginsdir>, so there are two entries. The second one could just be a copy of the original. - Run "perl misc/devel/install_plugins.pl" - Note the output looks something like this: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$ - Apply the patch and run the script again. Output should be: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins root@kohadevbox:koha(master)$ - Sign off Created attachment 164493 [details] [review] Bug 36517: Fix output from install_plugins.pl When misc/devel/install_plugins.pl does not find any plugins, it prints the list of pluginsdir, but with a literal \n separating the dirs, and no newline at the end. To test: - Edit koha-conf.xml and add a second entry for <pluginsdir>, so there are two entries. The second one could just be a copy of the original. - Run "perl misc/devel/install_plugins.pl" - Note the output looks something like this: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$ - Apply the patch and run the script again. Output should be: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins root@kohadevbox:koha(master)$ - Sign off Signed-off-by: David Nind <david@davidnind.com> Created attachment 164626 [details] [review] Bug 36517: Fix output from install_plugins.pl When misc/devel/install_plugins.pl does not find any plugins, it prints the list of pluginsdir, but with a literal \n separating the dirs, and no newline at the end. To test: - Edit koha-conf.xml and add a second entry for <pluginsdir>, so there are two entries. The second one could just be a copy of the original. - Run "perl misc/devel/install_plugins.pl" - Note the output looks something like this: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$ - Apply the patch and run the script again. Output should be: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins root@kohadevbox:koha(master)$ - Sign off Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Good catch - thanks, Mangus! Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 Not backporting to 22.11  |