Summary: | Incorrect path to enquire.js on self checkout slip print page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
Circulation function: | |||
Bug Depends on: | 29960 | ||
Bug Blocks: | |||
Attachments: |
Bug 36528: Correct JS assets included in self checkout slip template
Bug 36528: Correct JS assets included in self checkout slip template Bug 36528: Correct JS assets included in self checkout slip template |
Description
Owen Leonard
2024-04-04 19:41:43 UTC
Created attachment 164487 [details] [review] Bug 36528: Correct JS assets included in self checkout slip template The self checkout's slip print template includes some assets which it doesn't need (enquire.js) and lacks other that it does (i18n-related files). This patch correct the problem. The patch also wraps some code in global.js with a check that the relevant library has been loaded so that we don't get errors when the asset isn't included. To test, apply the patch and clear your browser cache. - With WebBasedSelfCheck enabled, log in to the self checkout module and check some items out. - Click "Finish" and then "Print receipt..." - Check the browser console on the receipt page. There should be no errors. - Log in to the OPAC and click the "Messaging" tab on the patron summary page. - Test that the "Digests only" table heading icon shows a tooltip. - Test that enquire.js is still loading correctly by performing a catalog search and narrowing your browser. When the window is narrow enough, the facets sidebar should collapse into a "Refine your search" button. Note that the "js_in_body" qa warning is a false positive. This patch contains changes to global.js automatically applied on commit by prettier. I'm not sure if that's the expected behavior or not. Created attachment 164492 [details] [review] Bug 36528: Correct JS assets included in self checkout slip template The self checkout's slip print template includes some assets which it doesn't need (enquire.js) and lacks other that it does (i18n-related files). This patch correct the problem. The patch also wraps some code in global.js with a check that the relevant library has been loaded so that we don't get errors when the asset isn't included. To test, apply the patch and clear your browser cache. - With WebBasedSelfCheck enabled, log in to the self checkout module and check some items out. - Click "Finish" and then "Print receipt..." - Check the browser console on the receipt page. There should be no errors. - Log in to the OPAC and click the "Messaging" tab on the patron summary page. - Test that the "Digests only" table heading icon shows a tooltip. - Test that enquire.js is still loading correctly by performing a catalog search and narrowing your browser. When the window is narrow enough, the facets sidebar should collapse into a "Refine your search" button. Note that the "js_in_body" qa warning is a false positive. Signed-off-by: David Nind <david@davidnind.com> Created attachment 166888 [details] [review] Bug 36528: Correct JS assets included in self checkout slip template The self checkout's slip print template includes some assets which it doesn't need (enquire.js) and lacks other that it does (i18n-related files). This patch correct the problem. The patch also wraps some code in global.js with a check that the relevant library has been loaded so that we don't get errors when the asset isn't included. To test, apply the patch and clear your browser cache. - With WebBasedSelfCheck enabled, log in to the self checkout module and check some items out. - Click "Finish" and then "Print receipt..." - Check the browser console on the receipt page. There should be no errors. - Log in to the OPAC and click the "Messaging" tab on the patron summary page. - Test that the "Digests only" table heading icon shows a tooltip. - Test that enquire.js is still loading correctly by performing a catalog search and narrowing your browser. When the window is narrow enough, the facets sidebar should collapse into a "Refine your search" button. Note that the "js_in_body" qa warning is a false positive. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Easy fix, well tested, no string changes. QA script failure is noted in the bug as a false positive. Pushing :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 In 23.11.x path lib/enquire.min.js is correct but patch still applies to remove this asset and changes in global.js Doesn't apply cleanly to 23.05.x, no backport. |