| Summary: | koha-elasticsearch commit default should be configurable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Searching - Elasticsearch | Assignee: | Robin Sheat <robin> |
| Status: | Signed Off --- | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 36550: allow defaults to be defined for koha-elasticsearch
Bug 36550: allow defaults to be defined for koha-elasticsearch |
||
|
Description
David Cook
2024-04-09 02:26:35 UTC
Created attachment 189821 [details] [review] Bug 36550: allow defaults to be defined for koha-elasticsearch koha-elasticsearch only allows the parameters to be specified on the command line, otherwise it'll fall back to values hard-coded in the script. This allows default parameters to be defined in /etc/default/koha-common when installed with the Debian packages. It also copies the current defaults into the defaults file. Test plan, comprehensive: 1. You will need a package setup with elasticsearch, and some records. 2. Build a package (or copy the files modified in this patch over ones you might already have installed) 3. Modify some ES_* values in /etc/default/koha-community to your liking. 'ES_VERBOSE' might be a good one. 4. Do an elasticsearch reindex and observe that your parameter defaults are respected. Test plan, simple: 1. With a git checkout: * `sudo ln -s .../koha/debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh` * `sudo ln -s .../koha/debian/koha-common.default /etc/default/koha-common` 2. Modify `.../koha/debian/scripts/koha-elasticsearch` around line 200 so that it prints out the variables, and see that it properly respects modifying the defaults and/or setting the command line arguments. Created attachment 189822 [details] [review] Bug 36550: allow defaults to be defined for koha-elasticsearch koha-elasticsearch only allows the parameters to be specified on the command line, otherwise it'll fall back to values hard-coded in the script. This allows default parameters to be defined in /etc/default/koha-common when installed with the Debian packages. It also copies the current defaults into the defaults file. Test plan, comprehensive: 1. You will need a package setup with elasticsearch, and some records. 2. Build a package (or copy the files modified in this patch over ones you might already have installed) 3. Modify some ES_* values in /etc/default/koha-community to your liking. 'ES_VERBOSE' might be a good one. 4. Do an elasticsearch reindex and observe that your parameter defaults are respected. Test plan, simple: 1. With a git checkout: * `sudo ln -s .../koha/debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh` * `sudo ln -s .../koha/debian/koha-common.default /etc/default/koha-common` 2. Modify `.../koha/debian/scripts/koha-elasticsearch` around line 200 so that it prints out the variables, and see that it properly respects modifying the defaults and/or setting the command line arguments. Signed-off-by: David Cook <dcook@prosentient.com.au> Shouldnt this be marked as enh ? |