Bug 3657

Summary: Editing MARC Authority Subfield Structure - Librarian Text is Mandatory
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: MARC Authority data supportAssignee: Galen Charlton <gmcharlt>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P5 - low CC: chris, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Chris Cormack 2010-05-21 01:13:23 UTC


---- Reported by colin.campbell@ptfs-europe.com 2009-09-23 14:01:06 ----

When adding or editing subfields in Administration/Authority MARC Structure changes or additions are not saved unless there is content in the Text for librarians field. Otherwise the insert/delete silently fails. People think this is a bug as there is no indication of this requirement other than in the code.

Will be submitting a patch to remove the requirement for text to be input in this field



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:13 UTC  ---

This bug was previously known as _bug_ 3657 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3657

Actual time not defined. Setting to 0.0

Comment 1 Owen Leonard 2010-06-29 13:45:56 UTC
http://lists.koha-community.org/pipermail/koha-patches/2009-September/010249.html

Patch no longer applies. Is this still an issue?
Comment 2 Colin Campbell 2010-06-29 14:10:11 UTC
Still an issue. Open to question whether we should rework the patch or make it obvious to the user that the field is mandatory which as originally pointed out is not documented anywhere other than in the code.
Comment 3 Chris Cormack 2010-12-15 03:56:36 UTC
Needs new patch or reworked patch
Comment 4 Jared Camins-Esakov 2013-01-02 01:32:51 UTC
Resetting to ASSIGNED since a new patch is required.
Comment 5 Owen Leonard 2016-02-29 19:06:31 UTC
Setting this to "New" since a new patch doesn't seem to be forthcoming. The problem still exists with both authority subfield structure and biblio subfield structure -- If you submit a new subfield without including librarian text the process fails silently.

There's a good reason: The "New" form fields are part of a big form which includes all the form fields for existing data. It needs to be possible to submit empty fields and thereby ignore the "New" part of the form. It (apparently) needs to also be possible to create a new subfield *without* a subfield code, so librarian text ends up being the field which is consulted to determine whether data in the "New" form is added.
Comment 6 Katrin Fischer 2018-05-16 00:53:38 UTC
Still valid. Can we not just mark the field as required the usual way?
Comment 7 Katrin Fischer 2023-10-07 22:30:42 UTC
(In reply to Katrin Fischer from comment #6)
> Still valid. Can we not just mark the field as required the usual way?

There is a catch here. We want the subfield code and the staff interface description to be required, but the form for a new subfield is always loaded. We only want it to trigger when something has been entered indicating a new field is to be added. I didn't manage to do that.