| Summary: | Checkouts table on patron account won't load if any of the items have item notes | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Component: | Circulation | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Status: | Needs documenting --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes an issue that prevented a patron's checkouts table from loading if any of their checked-out items had public or nonpublic notes.
|
Version(s) released in: |
24.05.00
|
| Circulation function: | |||
| Bug Depends on: | 35506 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36581: Define ymd in scope for checkouts table
Bug 36581: Define ymd in scope for checkouts table Bug 36581: Define ymd in scope for checkouts table |
||
|
Description
Emily Lamancusa (emlam)
2024-04-11 14:51:14 UTC
Created attachment 164760 [details] [review] Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone Created attachment 164761 [details] [review] Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Trivial one-line patch - self-SO Created attachment 164775 [details] [review] Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I suspect this is from the CSRF, but we should test this in older versions or uncover the fault (In reply to Nick Clemens from comment #5) > I suspect this is from the CSRF, but we should test this in older versions > or uncover the fault I think it's bug 35506. I'll test and confirm. (In reply to Emily Lamancusa from comment #6) > (In reply to Nick Clemens from comment #5) > > I suspect this is from the CSRF, but we should test this in older versions > > or uncover the fault > > I think it's bug 35506. I'll test and confirm. Confirmed - I'll add it a dependency. Pushed for 24.05! Well done everyone, thank you! |