Summary: | Advanced cataloging - restore the correct height of the clipboard | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Cataloging | Assignee: | Phil Ringnalda <phil> |
Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy, oleonard, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
Bug Depends on: | |||
Bug Blocks: | 27769 | ||
Attachments: |
Bug 36589: Advanced cataloging - restore the correct height of the clipboard
Bug 36589: Advanced cataloging - restore the correct height of the clipboard Bug 36589: Advanced cataloging - restore the correct height of the clipboard |
Description
Caroline Cyr La Rose
2024-04-12 09:03:51 UTC
I searched a bit in bugzilla and didn't find a bug that made the clipboard small, so I think it might be an unexpected side effect of the redesign or of another change... Sorry, me again. I normally test in Chrome, and I see 1.5ish lines in Chrome. But I just tried in Firefox and I find it worst. Only one line is shown in Firefox and there are no arrows to indicate that there actually are more than one line in the clipboard. "Before" picture: https://koha-community.org/manual/23.05/en/html/_images/advancedcataloging.png My current clipboard in Chrome, with 3 fields copied into the clipboard: https://snipboard.io/E1DTjA.jpg My current clipboard in Firefox, with 3 fields copied into it: https://snipboard.io/dRFVOI.jpg I use Ubuntu 22.04 with Chrome 123.0.6312.105 and Firefox is 124.0.1, if it's relevant. Chances are it has been that way since 21.05, from bug 21851 adding https://git.koha-community.org/Koha-community/Koha/src/commit/1ea4a11c2a88f7b23b482e071db48ae235beb42b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss#L240 though that might have only wound up applying after some other later change (or even after a browser change in how to deal with the combination of <select size="10" style="height: calc(1.5em + .75rem + 2px);"> which is what the HTML plus the CSS amount to). As the attempt to fix it in bug 27769 by just removing .brief from the parent fieldset shows, it does need to have the width: 100% it gets from fieldset.brief select so it doesn't start out with no width and grow to the width of any line copied into it, but it needs to avoid that one-line height. Created attachment 166856 [details] [review] Bug 36589: Advanced cataloging - restore the correct height of the clipboard A simple direct fix for the height of the advanced editor's clipboard, which is a <select size="10"> that's currently cut down to the height of one thick line by CSS intended for non-multiple, non-sized selects with dropdown menus. Test plan: 1. Set the pref EnableAdvancedCatalogingEditor to Enable 2. Cataloging -> Advanced editor 3. Note the Clipboard is a single line tall 4. Apply patch, shift+reload Advanced editor 5. Note the Clipboard is ten lines tall Created attachment 166911 [details] [review] Bug 36589: Advanced cataloging - restore the correct height of the clipboard A simple direct fix for the height of the advanced editor's clipboard, which is a <select size="10"> that's currently cut down to the height of one thick line by CSS intended for non-multiple, non-sized selects with dropdown menus. Test plan: 1. Set the pref EnableAdvancedCatalogingEditor to Enable 2. Cataloging -> Advanced editor 3. Note the Clipboard is a single line tall 4. Apply patch, shift+reload Advanced editor 5. Note the Clipboard is ten lines tall Signed-off-by: Owen Leonard <oleonard@myacpl.org> Filed bug 36897 to keep the next person to use a sized or multiple select in a sidebar from having to figure out the need to do this. Created attachment 167165 [details] [review] Bug 36589: Advanced cataloging - restore the correct height of the clipboard A simple direct fix for the height of the advanced editor's clipboard, which is a <select size="10"> that's currently cut down to the height of one thick line by CSS intended for non-multiple, non-sized selects with dropdown menus. Test plan: 1. Set the pref EnableAdvancedCatalogingEditor to Enable 2. Cataloging -> Advanced editor 3. Note the Clipboard is a single line tall 4. Apply patch, shift+reload Advanced editor 5. Note the Clipboard is ten lines tall Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |