Summary: | Add place hold option from patron checkout tab | ||
---|---|---|---|
Product: | Koha | Reporter: | Jane Wagner <jwagner> |
Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, oleonard, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Search to hold button on checkout tab screenshot
Search popup with Hold For button in results list screenshot Search popup with Hold For button in title display screenshot Search to hold alternative process, step 1 Search to hold alternative process, step 2 Search to hold alternative process, step 3 Search to hold alternative process, step 4 Proposed fix Revised fix |
Description
Chris Cormack
2010-05-21 01:13:24 UTC
Created attachment 2974 [details]
Search to hold alternative process, step 1
I've tested the "search to hold" feature developed by PTFS and found it a little cumbersome: Putting the "action" into a modal window creates complications because the window contains the whole interface, including possible actions unrelated to the goal of placing a hold. For instance, from within that window I could abandon my search and start checking out to another patron. I could launch another "search to hold" window within the first search to hold window!
I propose that instead of trying to juggle the borrowernumber as a GET variable passed among windows we set it as a session-limited cookie. In this screenshot of my proposed alternative, clicking the "Search to hold" button sets a cookie with the patron's borrowernumber and redirects you to the search screen.
Created attachment 2975 [details]
Search to hold alternative process, step 2
Created attachment 2976 [details]
Search to hold alternative process, step 3
On the search results page Koha checks for the cookie containing a borrowernumber. If it finds one, it displays a link to place a hold for that patron.
Created attachment 2977 [details]
Search to hold alternative process, step 4
If you click through to the detail page from the search results you'll find that the standard "Place hold" button is now a "split button." The default action of the button is the standard place hold behavior. If you click the optional menu you have the choice placing a hold for the patron Koha is currently tracking.
One question I haven't addressed yet: Should you be able to tell Koha to "forget" it was tracking that patron? If so, what is the best way/best place to handle that? I like your implementation of this a lot! Regarding your question: Maybe set the cookie on each patron scan, expire it after 5-10 minutes (or however long you think)? > Should you be able to tell Koha to
> "forget" it was tracking that patron?
After some discussion with Liz, I've added a couple of things:
1. The cookie will expire after a certain number of minutes. What's good? 10? 5?
2. The cookie will be deleted when you load a new patron on circulation.pl
Liz points out another feature which this should accommodate: The ability to place multiple holds from the search results screen for the remembered patron. Created attachment 2995 [details] [review] Proposed fix Pushed please test Got my branches mixed up and submitted the wrong patch! I've asked chris to revert it. I'll submit the correct one. Created attachment 3043 [details] [review] Revised fix Revision fixes some markup and corrects an error that would lead to the hold being initiated for the remembered patron when this was not intended. This bug is mentioned in: Fix for Bug 3659, Add place hold option from patron checkout tab http://lists.koha-community.org/pipermail/koha-patches/2011-January/013605.html [SIGNED-OFF]Fix for Bug 3659, Add place hold option from patron checkout tab http://lists.koha-community.org/pipermail/koha-patches/2011-January/013613.html Fix for Bug 3659, Add place hold option from patron checkout tab http://lists.koha-community.org/pipermail/koha-patches/2011-January/013726.html I confirm this is completed and works in master. Thanks Owen! |