Summary: | Cannot delete circulation desk | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | major | ||
Priority: | P5 - low | CC: | blawlor, fridolin.somers, gmcharlt, martin.renvoize, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | 36192 | ||
Bug Blocks: | |||
Attachments: |
Bug 36597: Fix deletion of circulation desks broken by CSRF
Bug 36597: Fix deletion of circulation desks broken by CSRF Bug 36597: Fix deletion of circulation desks broken by CSRF |
Description
Owen Leonard
2024-04-12 12:30:44 UTC
Created attachment 164844 [details] [review] Bug 36597: Fix deletion of circulation desks broken by CSRF Our CSRF work introduced a problem with deleting circulation desks: The "delete_confirm" does not need "cud-" because it's a GET operation leading to a POSTed deletion after the confirmation is submitted. To test, apply the patch and restart services. - Go to Administration -> Circulation desks. - If necessary, create a circulation desk. - Click the "Delete" button for you new desk. - You should be taken to a confirmation page which shows details of the desk you're deleting. - Confirming the deletion should result in deletion of the desk. Created attachment 164845 [details] [review] Bug 36597: Fix deletion of circulation desks broken by CSRF Our CSRF work introduced a problem with deleting circulation desks: The "delete_confirm" does not need "cud-" because it's a GET operation leading to a POSTed deletion after the confirmation is submitted. To test, apply the patch and restart services. - Go to Administration -> Circulation desks. - If necessary, create a circulation desk. - Click the "Delete" button for you new desk. - You should be taken to a confirmation page which shows details of the desk you're deleting. - Confirming the deletion should result in deletion of the desk. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 164988 [details] [review] Bug 36597: Fix deletion of circulation desks broken by CSRF Our CSRF work introduced a problem with deleting circulation desks: The "delete_confirm" does not need "cud-" because it's a GET operation leading to a POSTed deletion after the confirmation is submitted. To test, apply the patch and restart services. - Go to Administration -> Circulation desks. - If necessary, create a circulation desk. - Click the "Delete" button for you new desk. - You should be taken to a confirmation page which shows details of the desk you're deleting. - Confirming the deletion should result in deletion of the desk. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial fix, thanks Owen. Passing QA Pushed for 24.05! Well done everyone, thank you! 23.11.x not impacted |