Description
Caroline Cyr La Rose
2024-04-16 19:41:15 UTC
Created attachment 164991 [details] [review] Bug 36614: Restore 'phone' on the main patron search It disappeared at some point (history is tricky here, I didn't manage to track down what happened, it's a mess) This patch adds a phone column after the "name and address" one. It's hidden by default. Let me know what you think about this patch. I am wondering if the phone shouldn't actually be in the "name and address" column. (In reply to Jonathan Druart from comment #2) > I am wondering if the phone shouldn't actually be in the "name and address" > column. I thought about that too, but I like the idea of being able to sort by phone number. I tested and it works well, but in Administration > Table settings, the column is named memberresultst instead of phone. Created attachment 165017 [details] [review] Bug 36614: Restore 'phone' on the main patron search It disappeared at some point (history is tricky here, I didn't manage to track down what happened, it's a mess) This patch adds a phone column after the "name and address" one. It's hidden by default. (In reply to Caroline Cyr La Rose from comment #3) > I tested and it works well, but in Administration > Table settings, the > column is named memberresultst instead of phone. Oops, sorry! I agree with Caroline, it would be a nice touch to sort patrons by their phone numbers. Created attachment 165021 [details] [review] Bug 36614: Restore 'phone' on the main patron search It disappeared at some point (history is tricky here, I didn't manage to track down what happened, it's a mess) This patch adds a phone column after the "name and address" one. It's hidden by default. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thanks Jonathan! Created attachment 166021 [details] [review] Bug 36614: Restore 'phone' on the main patron search It disappeared at some point (history is tricky here, I didn't manage to track down what happened, it's a mess) This patch adds a phone column after the "name and address" one. It's hidden by default. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 |