Bug 36625

Summary: t/db_dependent/Koha/Biblio.t leaves test data in the database
Product: Koha Reporter: Emily Lamancusa (emlam) <emily.lamancusa>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to oldstable --- QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, jesse, jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.01,24.11.06
Circulation function:
Bug Depends on: 28478    
Bug Blocks:    
Attachments: Bug 36625: Run subtests in txn - Koha/Biblio.t
Bug 36625: Run subtests in txn - Koha/Biblio.t
Bug 36625: (follow-up) Restore subtest titles

Description Emily Lamancusa (emlam) 2024-04-17 15:53:21 UTC
To reproduce:
Prove t/db_dependent/Koha/Biblio.t
Look at the list of item types
Notice nonsense test values
Comment 1 Jonathan Druart 2025-05-26 10:34:42 UTC
Created attachment 182782 [details] [review]
Bug 36625: Run subtests in txn - Koha/Biblio.t

Test plan:
select count(*) from itemtypes;
run the tests
exectute the select query again
=> No itemtypes should have been created
Comment 2 Tomás Cohen Arazi (tcohen) 2025-05-26 12:55:09 UTC
This seems to be related to a bad rebase of bug 28478:


1b4bb5709299264e33b2fec7df174742c31f7ea7

it even reverted some normalization of the tests names.
Comment 3 Tomás Cohen Arazi (tcohen) 2025-05-26 14:42:51 UTC
Created attachment 182785 [details] [review]
Bug 36625: Run subtests in txn - Koha/Biblio.t

Test plan:
select count(*) from itemtypes;
run the tests
exectute the select query again
=> No itemtypes should have been created

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2025-05-26 14:42:54 UTC
Created attachment 182786 [details] [review]
Bug 36625: (follow-up) Restore subtest titles

Due to a bad rebase we ended up changing subtest names in commit 1b4bb5709299264e33b2fec7df174742c31f7ea7
This patch restores them and has no effect on the tests themselves.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Lucas Gass (lukeg) 2025-06-02 20:58:13 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Fridolin Somers 2025-06-18 13:19:17 UTC
I see in 25.05.x
Comment 7 Fridolin Somers 2025-06-18 13:23:02 UTC
Pushed to 24.11.x for 24.11.06
Comment 8 Paul Derscheid 2025-06-19 08:55:03 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03
Comment 9 Jesse Maseto 2025-07-07 15:28:30 UTC
Merge conflicts with 24.05.x.