Summary: | Add placeholder text to the search bar in the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement updates the style of the OPAC search bar's placeholder text, the text which is shown in the text field when the user has not entered any text. Previously the style of the placeholder made it look very much like text the user had typed. Now the placeholder is right-aligned and italic in order to distinguish it from regular text, while keeping a color which has accessible contrast.
|
Version(s) released in: |
24.11.00
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 37412 | ||
Attachments: |
Bug 36651: Add placeholder text to the search bar in the OPAC
Bug 36651: Add placeholder text to the search bar in the OPAC Bug 36651: Add placeholder text to the search bar in the OPAC Screenshot showing possible re-styling of placeholder text |
Description
Caroline Cyr La Rose
2024-04-19 14:38:38 UTC
Created attachment 167628 [details] [review] Bug 36651: Add placeholder text to the search bar in the OPAC This patch adds placeholder text to the OPAC search bar, with JavaScript to change the placeholder based on the user's search type selection. To test, apply the patch and go to the OPAC. - The search bar should by default have the placeholder "Search the catalog by keyword" - Change the search type (Author, Title, etc). The placeholder text should change accordingly. Created attachment 167653 [details] [review] Bug 36651: Add placeholder text to the search bar in the OPAC This patch adds placeholder text to the OPAC search bar, with JavaScript to change the placeholder based on the user's search type selection. To test, apply the patch and go to the OPAC. - The search bar should by default have the placeholder "Search the catalog by keyword" - Change the search type (Author, Title, etc). The placeholder text should change accordingly. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 167661 [details] [review] Bug 36651: Add placeholder text to the search bar in the OPAC This patch adds placeholder text to the OPAC search bar, with JavaScript to change the placeholder based on the user's search type selection. To test, apply the patch and go to the OPAC. - The search bar should by default have the placeholder "Search the catalog by keyword" - Change the search type (Author, Title, etc). The placeholder text should change accordingly. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> That's one of these changes I am not totally sure about. For me the difference between the typed in search terms and the placeholder text are visually not very strong. It might be related to not having the best screen, but that might make it a good test too. :) I am happy to push as is to get some more eyes/opinions maybe. We got plenty of time now. Pushed for 24.11! Well done everyone, thank you! Created attachment 168010 [details] Screenshot showing possible re-styling of placeholder text (In reply to Katrin Fischer from comment #4) > For me the difference between the typed in search terms and the placeholder > text are visually not very strong. We do have the capability of styling the placeholder differently than the normal text. That might make a good visual hint that the text isn't actually filling the input. Comment on attachment 168010 [details]
Screenshot showing possible re-styling of placeholder text
I like this, can I have it? :)
Enhancement will not be backported to 24.05.x series (In reply to Katrin Fischer from comment #7) > I like this, can I have it? :) See Bug 37412 |