|
Description
Owen Leonard
2024-04-22 16:34:33 UTC
Created attachment 165329 [details] [review] Bug 36671: Reindent item transfer template (branchtransfers.tt) This patch reindents the item transfer template so that it has consistent indentation, with tab indentation converted to space. To test, apply the patch and go to Circulation -> Transfer. Test some transfers, including transfers which trigger a hold notification. Everything should work correctly. If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. Created attachment 165330 [details] [review] Bug 36671: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 165340 [details] [review] Bug 36671: Reindent item transfer template (branchtransfers.tt) This patch reindents the item transfer template so that it has consistent indentation, with tab indentation coverted to space. To test, apply the patch and go to Circulation -> Transfer. Test some transfers, including transfers which trigger a hold notification. Everything should work correctly. If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 165341 [details] [review] Bug 36671: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 165342 [details] [review] Bug 36671: (follow-up) remove stray anchor tag Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 165366 [details] [review] Bug 36671: Reindent item transfer template (branchtransfers.tt) This patch reindents the item transfer template so that it has consistent indentation, with tab indentation coverted to space. To test, apply the patch and go to Circulation -> Transfer. Test some transfers, including transfers which trigger a hold notification. Everything should work correctly. If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 165367 [details] [review] Bug 36671: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 165368 [details] [review] Bug 36671: (follow-up) remove stray anchor tag Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice bit of cleanup, great work. Passing QA Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x Code formatting change, nothing to add/edit in the manual. |