Bug 36673

Summary: Limit search for used categories and item types to current library
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Staff interfaceAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: andrew, catrina, fridolin.somers, gmcharlt, lucas
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36668
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:
Bug Depends on: 36447    
Bug Blocks:    
Attachments: bug 36673: Filter used categories and item types to current branch
bug 36673: Filter used categories and item types to current branch
Bug 36673: Filter used categories and item types to current branch
Bug 36673: Filter used categories and item types to current branch

Description Nick Clemens (kidclamp) 2024-04-22 18:12:37 UTC
Bug 36447 limited the categories looped on the smart-rules page to those currently used - we can go a bit further and limit them to the current branch we are loading
Comment 1 Nick Clemens (kidclamp) 2024-04-22 18:13:49 UTC
Created attachment 165344 [details] [review]
bug 36673: Filter used categories and item types to current branch

To test:
1 - Define some circulation rules for default and specific branches
2 - Apply patch
3 - Confirm rules display as before
Comment 2 ByWater Sandboxes 2024-04-23 13:49:33 UTC
Created attachment 165401 [details] [review]
bug 36673: Filter used categories and item types to current branch

To test:
1 - Define some circulation rules for default and specific branches
2 - Apply patch
3 - Confirm rules display as before

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Pedro Amorim 2024-05-03 11:32:27 UTC Comment hidden (obsolete)
Comment 4 Pedro Amorim 2024-05-03 11:33:33 UTC
Created attachment 166110 [details] [review]
Bug 36673: Filter used categories and item types to current branch

To test:
1 - Define some circulation rules for default and specific branches
2 - Apply patch
3 - Confirm rules display as before

PA amended:
- bug->Bug in commit title
- squashed tidy

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-05-03 14:04:05 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-24 13:01:35 UTC
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass (lukeg) 2024-05-28 21:27:50 UTC
Missing dependencies for 23.05.x, no backport.