Summary: | Why is DUE all caps on enhanced messages | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Notices | Assignee: | Nicole C. Engard <nengard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, julian.maurice, koha.sekjal |
Version: | Main | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed patch
updated patch for english only |
Description
Chris Cormack
2010-05-21 01:13:32 UTC
This is marked fixed, but I can't find a record of this commit - has this been committed into 3.2? It's a simple little fix that doesn't change any features or strings (not really) so I'd love to see it in 3.2 if it's not already. adding bugs list to qa to get an answer to previous comment was never really fixed or pushed - reopening until the patch is pushed. I see a translation problem here. The message_attributes table is part of the sql files that get translated. There should be no update to the database, only a change for new ones. Or an updatedatabase that checks for the existing of DUE. I'll update it to only update it if it says 'DUE' but we do need a db update because so many people have it that way right now and it DRIVES ME CRAZY!! :) Created attachment 3004 [details] [review] updated patch for english only Patch pushed, please test and marked resolved The database change works fine, but the display in the staff client is now broken. Since the value of the notice no longer matches "Item DUE", the messaging-preferences-form.inc file falls down to labelling the notices as "Unknown". Working on a patch. follow up patch signed off and sent to the list Follow up patch pushed, test Tested on master, "Item Due" is displayed correctly. |