Bug 36709

Summary: Add --confirm flag to update_localuse_from_statistics.pl script
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Command-line UtilitiesAssignee: Lucas Gass (lukeg) <lucas>
Status: Needs documenting --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, robin
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 16122    
Bug Blocks: 37790    
Attachments: Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script
Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script
Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script

Description Lucas Gass (lukeg) 2024-04-26 14:07:38 UTC
From https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122#c116 

The script should have a --confirm flag
Comment 1 Lucas Gass (lukeg) 2024-04-29 20:42:40 UTC
Created attachment 165807 [details] [review]
Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script

To test:
1. APPLY PATCH and restart all
2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens.
3. Run the script and add the --confirm flag, stuff happens.
Comment 2 Katrin Fischer 2024-04-30 07:50:08 UTC
This is an addition to an already pushed new script - makes sense to have in 24.05!
Comment 3 Matt Blenkinsop 2024-04-30 10:45:54 UTC
Created attachment 165839 [details] [review]
Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script

To test:
1. APPLY PATCH and restart all
2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens.
3. Run the script and add the --confirm flag, stuff happens.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-05-07 09:28:34 UTC
Created attachment 166244 [details] [review]
Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script

To test:
1. APPLY PATCH and restart all
2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens.
3. Run the script and add the --confirm flag, stuff happens.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-05-07 09:29:01 UTC
Simple addition here.. works as designed.

Passing QA
Comment 6 Katrin Fischer 2024-05-07 13:56:18 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-24 14:16:04 UTC
Depends on Bug 16122 not in 23.11.x