Summary: | Add cartographic mathematical data to Elasticsearch index mappings | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Searching - Elasticsearch | Assignee: | Danyon Sewell <danyonsewell> |
Status: | Needs Signoff --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | danyonsewell, david, laurence.rault, wainuiwitikapark |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings
Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings |
Description
Aleisha Amohia
2024-04-30 04:56:58 UTC
Created attachment 167426 [details] [review] Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Have written a patch to allow cartographic mathematical data to be searched using the default keyword search index. Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page) 4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 5. Alternative to steps 3 and 4: reset_all 6. Update the visibility for 255$a & 255$b in the default framework so that it is visible in the Editor. 7. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 8. Using the basic keyword search, search for the terms you put in step 7. Hey Danyon, this looks great and is almost there. Just a few changes to make: 1. Rename the patch to: Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings (just moving the colon) 2. the `label` of the index needs to have no spaces, it's the name of the index. For eg: cartographic-mathematical-data 3. When a mapping uses multiple subfields from the same tag, you can consolidate them like this: marc_field: '255ab' Can you please make those changes and reattach the patch? Created attachment 167428 [details] [review] Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings ah my mistake, thanks for the pointers. Have gone ahead and made the requested changes. Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page) 4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 5. Alternative to steps 3 and 4: reset_all 6. Update the visibility for 255$a & 255$b in the default framework so that it is visible in the Editor. 7. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 8. Using the basic keyword search, search for the terms you put in step 7. There is a sha1/fake ancestor error when applying the patch: git bz apply 36724 Bug 36724 - Add cartographic mathematical data to Elasticsearch index mappings 167428 - Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings error: sha1 information is lacking or useless (admin/searchengine/elasticsearch/mappings.yaml). error: could not build fake ancestor Patch failed at 0001 Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Created attachment 167647 [details] [review] Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Have reattached the patch hopefully this time without any sha1/fake ancestor errors. Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page) 4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 5. Alternative to steps 3 and 4: reset_all 6. Update the visibility for 255$a & 255$b in the default framework so that it is visible in the Editor. 7. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 8. Using the basic keyword search, search for the terms you put in step 7. Testing plan works as expected. However, I don't understand why the index cartographic-mathematical-data is added as a new label in "abstract" search field in the mappings.yaml file instead of being apart : biblios: abstract: label: abstract mandatory: ~ mappings: - facet: '' marc_field: '520' marc_type: marc21 sort: 1 suggestible: '' opac: 1 staff_client: 1 type: '' label: cartographic-mathematical-data mandatory: ~ mappings: - facet: '' marc_field: '255ab' marc_type: marc21 sort: 1 suggestible: '' opac: 1 staff_client: 1 type: '' |