Bug 36738

Summary: Date attributes follow-ups
Product: Koha Reporter: Shi Yao Wang <shi-yao.wang>
Component: PatronsAssignee: Shi Yao Wang <shi-yao.wang>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: caroline.cyr-la-rose, david, fridolin.somers, gmcharlt, kyle.m.hall, philippe.blouin
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 32610    
Bug Blocks:    
Attachments: Bug 36738: Date attributes follow-ups
Bug 36738: Date attributes follow-ups

Description Shi Yao Wang 2024-04-30 19:00:42 UTC
Continuation of bz32610

Make date attributes input empty when repeating.
Comment 1 Shi Yao Wang 2024-04-30 19:08:46 UTC
Created attachment 165927 [details] [review]
Bug 36738: Date attributes follow-ups

Make the repeatable date patron attribute empty when repeating the
inputs to avoid date formatting problems (and keeping past date value
after repeating is not something we want)

Test plan:
1- create a patron attribute type with is a date and repeatable checked
(administration -> patron attribute types)
2- add a couple of patron attribute of type date, notice the repeated
inputs contain previous data
3- Apply the patch
4- redo step 2 and notice the repeated inputs are empty

https://bugs.koha-community.org/show_bug.cgi?id=32610
Comment 2 David Nind 2024-04-30 21:29:07 UTC
Created attachment 165935 [details] [review]
Bug 36738: Date attributes follow-ups

Make the repeatable date patron attribute empty when repeating the
inputs to avoid date formatting problems (and keeping past date value
after repeating is not something we want)

Test plan:
1- create a patron attribute type with is a date and repeatable checked
(administration -> patron attribute types)
2- add a couple of patron attribute of type date, notice the repeated
inputs contain previous data
3- Apply the patch
4- redo step 2 and notice the repeated inputs are empty

Follow up for bug 32610 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610)

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-04-30 21:30:31 UTC
I amended the commit message so that the link to the original bug works.
Comment 4 Katrin Fischer 2024-05-03 08:37:59 UTC
Small change, tested, treating as a normal follow-up to bug 32610.
Comment 5 Katrin Fischer 2024-05-03 09:00:07 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-24 12:58:18 UTC
Depends on Bug 32610 not in 23.11.x
Comment 7 Caroline Cyr La Rose 2024-07-11 16:49:11 UTC
Documented as part of bug 32610