| Summary: | Option to place multiple holds on single bib should not be hidden when holds per record is unlimited | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Hold requests | Assignee: | Andrew Fuerste-Henry <andrew> |
| Status: | RESOLVED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | emily.lamancusa, fridolin.somers, gmcharlt, lucas |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 36775: Allow multiple holds on record when holds per record is unlimited
Bug 36775: Allow multiple holds on record when holds per record is unlimited Bug 36775: Allow multiple holds on record when holds per record is unlimited Bug 36775: Allow multiple holds on record when holds per record is unlimited Bug 36775: (QA follow-up) Remove max_length attribute |
||
|
Description
Andrew Fuerste-Henry
2024-05-03 16:21:04 UTC
Created attachment 166152 [details] [review] Bug 36775: Allow multiple holds on record when holds per record is unlimited To test: 1 set Holds Per Record to Unlimited 2 confirm hold placement interface does not include "Holds to place (count)" 3 apply patch, restart all 4 reload hold placement interface, confirm it does include "Holds to place (count)" 5 set Holds Per Record to 2 6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second 7 set Holds Per Record to 1 8 confirm Holds to Place does not show 9 sign off and eat a nice snack Created attachment 166158 [details] [review] Bug 36775: Allow multiple holds on record when holds per record is unlimited To test: 1 set Holds Per Record to Unlimited 2 confirm hold placement interface does not include "Holds to place (count)" 3 apply patch, restart all 4 reload hold placement interface, confirm it does include "Holds to place (count)" 5 set Holds Per Record to 2 6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second 7 set Holds Per Record to 1 8 confirm Holds to Place does not show 9 sign off and eat a nice snack Signed-off-by: David Nind <david@davidnind.com> Patch does not apply. :( (In reply to Emily Lamancusa from comment #3) > Patch does not apply. :( Sorry, you don't get the nice snack from the test plan :( Created attachment 166467 [details] [review] Bug 36775: Allow multiple holds on record when holds per record is unlimited To test: 1 set Holds Per Record to Unlimited 2 confirm hold placement interface does not include "Holds to place (count)" 3 apply patch, restart all 4 reload hold placement interface, confirm it does include "Holds to place (count)" 5 set Holds Per Record to 2 6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second 7 set Holds Per Record to 1 8 confirm Holds to Place does not show 9 sign off and eat a nice snack Created attachment 166468 [details] [review] Bug 36775: Allow multiple holds on record when holds per record is unlimited To test: 1 set Holds Per Record to Unlimited 2 confirm hold placement interface does not include "Holds to place (count)" 3 apply patch, restart all 4 reload hold placement interface, confirm it does include "Holds to place (count)" 5 set Holds Per Record to 2 6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second 7 set Holds Per Record to 1 8 confirm Holds to Place does not show 9 sign off and eat a nice snack Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 166469 [details] [review] Bug 36775: (QA follow-up) Remove max_length attribute The existing code for "Holds to place (count)" sets the input field's maxlength to remaining_holds_for_record, which does not do what we want and makes the field unusable when the circulation rules allow unlimited holds. Better to remove it. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Does tea count as a snack? :) Pushed for 24.05! Well done everyone, thank you! (In reply to Emily Lamancusa from comment #8) > Does tea count as a snack? :) After some deliberation, I do not feel qualified to answer this question. We'll have to consult the broader community. Does not apply on 23.11.x maybe some dependancy |