Summary: | Limit POSIX imports | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | Architecture, internals, and plumbing | Assignee: | Janusz Kaczmarek <januszop> |
Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, fridolin.somers, lucas, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
Circulation function: | |||
Bug Depends on: | 36552 | ||
Bug Blocks: | |||
Attachments: |
Bug 36792: Limit POSIX imports
Bug 36792: Limit POSIX imports |
Description
Janusz Kaczmarek
2024-05-06 12:03:28 UTC
Good catch. So we must add qw() Are you submitting the fix? Created attachment 166216 [details] [review] Bug 36792: Limit POSIX imports A Marcel's QA patch to Bug 36552 added use POSIX; in two spots. In https://metacpan.org/pod/POSIX we read: CAVEATS Everything is exported by default (with a handful of exceptions). This is an unfortunate backwards compatibility feature and its use is strongly discouraged. You should either prevent the exporting (by saying use POSIX ();, as usual) and then use fully qualified names (e.g. POSIX::SEEK_END), or give an explicit import list. If you do neither and opt for the default (as in use POSIX;), you will import hundreds and hundreds of symbols into your namespace. This patch fixes this. No test plan. Created attachment 166217 [details] [review] Bug 36792: Limit POSIX imports A Marcel's QA patch to Bug 36552 added use POSIX; in two spots. In https://metacpan.org/pod/POSIX we read: CAVEATS Everything is exported by default (with a handful of exceptions). This is an unfortunate backwards compatibility feature and its use is strongly discouraged. You should either prevent the exporting (by saying use POSIX ();, as usual) and then use fully qualified names (e.g. POSIX::SEEK_END), or give an explicit import list. If you do neither and opt for the default (as in use POSIX;), you will import hundreds and hundreds of symbols into your namespace. This patch fixes this. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial patch, directly in PQA Thanks Janusz Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x (In reply to Fridolin Somers from comment #7) > Not backported to 23.11.x Hi Fridolin, please, take into account that if you have taken Bug 36552 for 23.11 you should most probably take also this one... (In reply to Janusz Kaczmarek from comment #8) > (In reply to Fridolin Somers from comment #7) > > Not backported to 23.11.x > > Hi Fridolin, please, take into account that if you have taken Bug 36552 for > 23.11 you should most probably take also this one... Oh indeed, thanks for the alert Pushed to 23.11.x for 23.11.06 Enhancement will not be backported to 23.05.x (In reply to Lucas Gass from comment #11) > Enhancement will not be backported to 23.05.x Hi Lucas, please, take into account that if you have taken Bug 36552 for 23.05 you should most probably take also this one... (In reply to Janusz Kaczmarek from comment #12) > (In reply to Lucas Gass from comment #11) > > Enhancement will not be backported to 23.05.x > > Hi Lucas, please, take into account that if you have taken Bug 36552 for > 23.05 you should most probably take also this one... Thanks Janusz, I will backport it. Backported to 23.05.x for upcoming 23.05.12 |