| Summary: | OPAC - Patron 'submit update request' does not work for clearing patron attribute types | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
| Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to oldoldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, m.de.rooy, oleonard, tomascohen, wainuiwitikapark |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36761 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.13
|
|
| Circulation function: | |||
| Bug Depends on: | 35929, 22844 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36816: Restore clearing patron attributes - OPAC
Bug 36816: Remove warning Bug 36816: Restore clearing patron attributes - OPAC Bug 36816: Remove warning Bug 36816: Restore clearing patron attributes - OPAC Bug 36816: Remove warning |
||
|
Description
Pedro Amorim
2024-05-08 13:48:18 UTC
Might be caused by commit 54cf5e897bc681aa06cefa0e062d21a24723b84b Bug 22844: Make the patron's attribute mandatory at the OPAC Will write a fix on top of bug 35929 that is already signed off. Created attachment 167008 [details] [review] Bug 36816: Restore clearing patron attributes - OPAC 1) Add a new patron attribute type, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type 2) Add a code and a description (whatever) - Make it 'Display in OPAC' and 'Editable in OPAC' 3) Access OPAC patron personal details page, visit: <opac_url>/cgi-bin/koha/opac-memberentry.pl 4) Scroll down and add some info to 'whatever'. Click 'Submit update request'. 5) Visit the INTRA 'update patron requests from opac' page: <staff_url>/cgi-bin/koha/members/members-update.pl 6) Notice the entry is there. Select 'approve' and click "Submit" 7) Repeat 3) 8) Scroll down and notice the approved value is there. Clear that data and "Submit update request" (as if you're requesting for that data to be removed/cleared) 9) Repeat 5) 10) Notice there's an entry, and it is not empty. Select 'approve' and click "Submit" 11) Repeat 3) 12) Scroll down and notice the request to update (clear) that field did go through, i.e. the data is not there anymore. Also test self-registration and mandatory attributes Created attachment 167009 [details] [review] Bug 36816: Remove warning Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629. Created attachment 167042 [details] [review] Bug 36816: Restore clearing patron attributes - OPAC 1) Add a new patron attribute type, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type 2) Add a code and a description (whatever) - Make it 'Display in OPAC' and 'Editable in OPAC' 3) Access OPAC patron personal details page, visit: <opac_url>/cgi-bin/koha/opac-memberentry.pl 4) Scroll down and add some info to 'whatever'. Click 'Submit update request'. 5) Visit the INTRA 'update patron requests from opac' page: <staff_url>/cgi-bin/koha/members/members-update.pl 6) Notice the entry is there. Select 'approve' and click "Submit" 7) Repeat 3) 8) Scroll down and notice the approved value is there. Clear that data and "Submit update request" (as if you're requesting for that data to be removed/cleared) 9) Repeat 5) 10) Notice there's an entry, and it is not empty. Select 'approve' and click "Submit" 11) Repeat 3) 12) Scroll down and notice the request to update (clear) that field did go through, i.e. the data is not there anymore. Also test self-registration and mandatory attributes Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 167043 [details] [review] Bug 36816: Remove warning Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 167159 [details] [review] Bug 36816: Restore clearing patron attributes - OPAC 1) Add a new patron attribute type, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type 2) Add a code and a description (whatever) - Make it 'Display in OPAC' and 'Editable in OPAC' 3) Access OPAC patron personal details page, visit: <opac_url>/cgi-bin/koha/opac-memberentry.pl 4) Scroll down and add some info to 'whatever'. Click 'Submit update request'. 5) Visit the INTRA 'update patron requests from opac' page: <staff_url>/cgi-bin/koha/members/members-update.pl 6) Notice the entry is there. Select 'approve' and click "Submit" 7) Repeat 3) 8) Scroll down and notice the approved value is there. Clear that data and "Submit update request" (as if you're requesting for that data to be removed/cleared) 9) Repeat 5) 10) Notice there's an entry, and it is not empty. Select 'approve' and click "Submit" 11) Repeat 3) 12) Scroll down and notice the request to update (clear) that field did go through, i.e. the data is not there anymore. Also test self-registration and mandatory attributes Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 167160 [details] [review] Bug 36816: Remove warning Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Pushed to 23.05.x for 23.05.13 |