Bug 36824

Summary: Fix conversion of __VERSION__ in system preferences to use main rather than master
Product: Koha Reporter: Phil Ringnalda <phil>
Component: System AdministrationAssignee: Phil Ringnalda <phil>
Status: RESOLVED FIXED QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, gmcharlt, tomascohen
Version: MainKeywords: rel_24_05_candidate
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Attachments: Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master

Description Phil Ringnalda 2024-05-09 23:17:47 UTC
The descriptions of EmailFieldPrecedence and PatronSelfModificationMandatoryField have links to schema.koha-community.org which insert the running version into the URL. For development versions, those need to be inserting /main/ rather than /master/.
Comment 1 Phil Ringnalda 2024-05-09 23:31:33 UTC
Well, a few more than just those two, counting is hard. Luckily, if one works they all work.
Comment 2 Phil Ringnalda 2024-05-09 23:36:20 UTC
Created attachment 166480 [details] [review]
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master

Test plan:
1. Administration > search system preferences for the words database columns
2. Click the links to schema.koha-community.org, note that they 404 with
   /master/ in the URL
3. Apply patch, reset_all
4. Search again, click the links, note that they load successfully with /main/
Comment 3 Chris Cormack 2024-05-10 00:05:37 UTC
Created attachment 166482 [details] [review]
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master

Test plan:
1. Administration > search system preferences for the words database columns
2. Click the links to schema.koha-community.org, note that they 404 with
   /master/ in the URL
3. Apply patch, reset_all
4. Search again, click the links, note that they load successfully with /main/

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Tomás Cohen Arazi (tcohen) 2024-05-10 12:10:52 UTC
Created attachment 166533 [details] [review]
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master

Test plan:
1. Administration > search system preferences for the words database columns
2. Click the links to schema.koha-community.org, note that they 404 with
   /master/ in the URL
3. Apply patch, reset_all
4. Search again, click the links, note that they load successfully with /main/

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Katrin Fischer 2024-05-10 12:21:23 UTC
Thx for finding and fixing these, Phil!
Comment 6 Katrin Fischer 2024-05-10 13:20:29 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-29 08:43:09 UTC
Not for 23.11.x
Comment 8 Aude Charillon 2024-05-30 16:28:54 UTC
No update to the Koha Manual needed.