| Summary: | Incorrect instantiations of CGI ::-> | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, julian.maurice, m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
(In reply to Jonathan Druart from comment #0) > Koha/Uploader.pm: my $query = CGI::->new( sub { $self->_hook(@_); }, {}, > 0 ); > opac/opac-retrieve-file.pl:my $input = CGI::->new; > tools/upload.pl:my $input = CGI::->new; > > This ::-> looks wrong It is not wrong. And theoretically perhaps even safer. But not consistent. Indeed it is correct: https://perldoc.perl.org/perlobj#Invoking-Class-Methods Marking as invalid or we update for consistency? (In reply to Jonathan Druart from comment #3) > Marking as invalid or we update for consistency? If those three are the only ones, I would not mind updating. (In reply to Julian Maurice from comment #2) > Indeed it is correct: https://perldoc.perl.org/perlobj#Invoking-Class-Methods Learn something new every day... |
Koha/Uploader.pm: my $query = CGI::->new( sub { $self->_hook(@_); }, {}, 0 ); opac/opac-retrieve-file.pl:my $input = CGI::->new; tools/upload.pl:my $input = CGI::->new; This ::-> looks wrong