Bug 36830

Summary:	Unable to delete a holiday
Product:	Koha	Reporter:	Pedro Amorim <pedro.amorim>
Component:	Staff interface	Assignee:	Pedro Amorim <pedro.amorim>
Status:	RESOLVED FIXED	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	normal
Priority:	P5 - low	CC:	david, fridolin.somers, gmcharlt, jonathan.druart, m.de.rooy, martin.renvoize, oleonard
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00
Circulation function:
Attachments:	Bug 36830: Update delete -> cud-delete Bug 36830: Update delete -> cud-delete Bug 36830: Update delete -> cud-delete

Description Pedro Amorim 2024-05-10 14:14:32 UTC

Comment 1 Pedro Amorim 2024-05-10 14:15:59 UTC

Created attachment 166569 [details] [review]
Bug 36830: Update delete -> cud-delete

1) Visit <staff_url>/cgi-bin/koha/tools/holidays.pl
2) Select "Holiday only on this day" (or whatever other option to add an holiday). Click 'Save.
3) Now click on that day in the calendar, pick "delete this holiday". Click 'Save'. Notice the holiday is still there.
4) Apply patch. Repeat. Notice its deleted.

Comment 2 Martin Renvoize (ashimema) 2024-05-10 14:21:44 UTC

Created attachment 166574 [details] [review]
Bug 36830: Update delete -> cud-delete

1) Visit <staff_url>/cgi-bin/koha/tools/holidays.pl
2) Select "Holiday only on this day" (or whatever other option to add an holiday). Click 'Save.
3) Now click on that day in the calendar, pick "delete this holiday". Click 'Save'. Notice the holiday is still there.
4) Apply patch. Repeat. Notice its deleted.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 3 Brendan Lawlor 2024-05-10 14:32:33 UTC

Created attachment 166575 [details] [review]
Bug 36830: Update delete -> cud-delete

1) Visit <staff_url>/cgi-bin/koha/tools/holidays.pl
2) Select "Holiday only on this day" (or whatever other option to add an holiday). Click 'Save.
3) Now click on that day in the calendar, pick "delete this holiday". Click 'Save'. Notice the holiday is still there.
4) Apply patch. Repeat. Notice its deleted.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Comment 4 Katrin Fischer 2024-05-10 14:47:11 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 5 Fridolin Somers 2024-05-29 09:19:16 UTC

Not for 23.11.x

Comment 6 Aude Charillon 2024-05-30 16:23:48 UTC

No update to the Koha Manual needed.