Summary: | Adding authority records is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | MARC Authority data support | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | emily.lamancusa, fridolin.somers, januszop, lucas, mengu, phil, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
Circulation function: | |||
Bug Depends on: | 36791 | ||
Bug Blocks: | |||
Attachments: |
Bug 36832: (bug 36791 follow-up) Allow authid=0
Bug 36832: (bug 36791 follow-up) Allow authid=0 Bug 36832: (bug 36791 follow-up) Allow authid=0 Bug 36832: (bug 36791 follow-up) Allow authid=0 Bug 36832: (bug 36791 follow-up) Allow authid=0 |
Description
Katrin Fischer
2024-05-10 15:44:51 UTC
That's the patch from bug 36791 which failed to realize that z3950_auth_search.pl passes back ?authid=0 when it isn't replacing an existing authority. Thanks Phil! Created attachment 166592 [details] [review] Bug 36832: (bug 36791 follow-up) Allow authid=0 To test: 1. Go to the Authorities module and do a Z39.50 search that will return results (e.g. a general subject heading) 2. Import an authority record from the results --> Confirm that the record is imported into the editor Thanks, Phil! Give it a try with the above patch Created attachment 166604 [details] [review] Bug 36832: (bug 36791 follow-up) Allow authid=0 To test: 1. Go to the Authorities module and do a Z39.50 search that will return results (e.g. a general subject heading) 2. Import an authority record from the results --> Confirm that the record is imported into the editor 3. Authorities > New, replace it via Z39.50, confirm it's imported 4. Authorities > New, fill the required fields, confirm it saves 5. Edit an existing authority, replace it via Z39.50, confirm it saves 6. Edit an existing authority, replace authid=nn in the URL with a number that doesn't exist like 1000000, confirm you get a 404 page Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 166605 [details] [review] Bug 36832: (bug 36791 follow-up) Allow authid=0 To test: 1. Go to the Authorities module and do a Z39.50 search that will return results (e.g. a general subject heading) 2. Import an authority record from the results --> Confirm that the record is imported into the editor Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Created attachment 166606 [details] [review] Bug 36832: (bug 36791 follow-up) Allow authid=0 To test: 1. Go to the Authorities module and do a Z39.50 search that will return results (e.g. a general subject heading) 2. Import an authority record from the results --> Confirm that the record is imported into the editor 3. Authorities > New, replace it via Z39.50, confirm it's imported 4. Authorities > New, fill the required fields, confirm it saves 5. Edit an existing authority, replace it via Z39.50, confirm it saves 6. Edit an existing authority, replace authid=nn in the URL with a number that doesn't exist like 1000000, confirm you get a 404 page Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> I fleshed out the test plan because my patch to z3950_auth_search.tt to not output the silly authid=0 only fixed some cases, not all. Colliding signoffs is a nice problem to have :) (In reply to Phil Ringnalda from comment #8) > Colliding signoffs is a nice problem to have :) Yes, and colliding patches--I had a patch ready, but Emily was like two minutes faster ;) Anyway, thanks for the catch! Created attachment 166613 [details] [review] Bug 36832: (bug 36791 follow-up) Allow authid=0 To test: 1. Go to the Authorities module and do a Z39.50 search that will return results (e.g. a general subject heading) 2. Import an authority record from the results --> Confirm that the record is imported into the editor 3. Authorities > New, replace it via Z39.50, confirm it's imported 4. Authorities > New, fill the required fields, confirm it saves 5. Edit an existing authority, replace it via Z39.50, confirm it saves 6. Edit an existing authority, replace authid=nn in the URL with a number that doesn't exist like 1000000, confirm you get a 404 page Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |