Summary: | Can't approve or reject tags in the staff interface | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | 34478 | ||
Bug Blocks: | |||
Attachments: |
Bug 36838: Add CSRF token to tags review AJAX requests
Bug 36838: Add CSRF token to tags review AJAX requests |
Description
Owen Leonard
2024-05-13 13:39:55 UTC
Created attachment 166638 [details] [review] Bug 36838: Add CSRF token to tags review AJAX requests The JavaScript for approving or rejecting tags in the staff interface's tag review interface lacked a CSRF token for the POSTed requests. This patch adds the token for "approve" and "reject" operations. To test, apply the patch and clear your browser cache if necessary. - If necessary, enable tags in system preferences. - Log in to the OPAC and submit multiple tags on various records. - In the staff interface, go to Tools -> Tags. - Test the process of approving and rejecting tags by clicking the buttons in each row of the table of tags. - The browser console should show no errors, and the lists of approved and rejected tags should correctly show the tags you moderated. Created attachment 166639 [details] [review] Bug 36838: Add CSRF token to tags review AJAX requests The JavaScript for approving or rejecting tags in the staff interface's tag review interface lacked a CSRF token for the POSTed requests. This patch adds the token for "approve" and "reject" operations. To test, apply the patch and clear your browser cache if necessary. - If necessary, enable tags in system preferences. - Log in to the OPAC and submit multiple tags on various records. - In the staff interface, go to Tools -> Tags. - Test the process of approving and rejecting tags by clicking the buttons in each row of the table of tags. - The browser console should show no errors, and the lists of approved and rejected tags should correctly show the tags you moderated. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.05! Well done everyone, thank you! |