Bug 36841

Summary: Don't separate KTD and maintainer in about-team.inc
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: I18N/L10NAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: f.demians, jonathan.druart, julian.maurice
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Caroline Cyr La Rose 2024-05-13 14:48:00 UTC
In about-team.inc, there are these strings

            <li><strong><a href="https://gitlab.com/koha-community/koha-testing-docker">KTD</a> maintainer:</strong>


            <li><strong><a href="https://gitlab.com/koha-community/koha-testing-docker">KTD</a> maintainers:</strong>


In the translation tool, this comes out as

- KTD
- maintainer:
- maintainers:

However, in French the sentence structure needs to be inverted (becoming "maintainer of KTD"). This is currently impossible to translate with the strings separated as they are.
Comment 1 Caroline Cyr La Rose 2024-05-13 14:53:45 UTC
I tried putting <span> around the strings, but it doesn't change the staff-prog.po file... Maybe I'm not putting them in the right place?

        [% IF t.ktd %]
             [% IF t.ktd.size == 1 %]
            <li><span><strong><a href="https://gitlab.com/koha-community/koha-testing-docker">KTD</a> maintainer:</strong></span>
                [% INCLUDE person p=t.ktd.0 %]
            </li>
            [% ELSE %]
            <li><span><strong><a href="https://gitlab.com/koha-community/koha-testing-docker">KTD</a> maintainers:</strong></span>
                <ul>
                    [% FOREACH j IN t.ktd %]
                    <li>[% INCLUDE person p=j %]
                    [% END %]
                </ul>
            </li>
            [% END %]
        [% END %]

After `gulp po:update --lang fr-CA`, the fr-CA-staff-prog.po file still has the three strings separated.

#: koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc:214
#: koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc:218
#, c-format
msgid "KTD"
msgstr ""

#: koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc:214
#, c-format
msgid "maintainer:"
msgstr ""

#: koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc:218
#, c-format
msgid "maintainers:"
msgstr ""
Comment 2 Julian Maurice 2024-05-14 06:28:13 UTC
You can try using '18n.inc' macros. For instance:

[% tx("{ktd} maintainers", ktd = '<a href="...">KTD</a>') %]

That way you can translate it to "mainteneurs de {ktd}"