Summary: | Further improvements to holds request page | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Hold requests | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Needs documenting --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This is part of improvements to placing holds from the record page in the staff interface.
It adds a tick icon with a green background to the section selected (either 'Hold next available item' or 'Hold a specific item').
It prevents selecting drop down lists in the section not selected.
|
Version(s) released in: |
24.05.00
|
Circulation function: | |||
Bug Depends on: | 30579 | ||
Bug Blocks: | 36899 | ||
Attachments: |
Bug 36864: Add classes/CSS/fix markup on request.tt
Bug 36864: Add a font awesome icon to indicate enabled Bug 36864: Add classes/CSS/fix markup on request.tt Bug 36864: Add a font awesome icon to indicate enabled Bug 36864: Add classes/CSS/fix markup on request.tt Bug 36864: Add a font awesome icon to indicate enabled |
Description
Lucas Gass (lukeg)
2024-05-14 21:06:04 UTC
Created attachment 166743 [details] [review] Bug 36864: Add classes/CSS/fix markup on request.tt To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Place a hold 4. On reserve/request.pl the 'Hold a specific item' fieldset should be disabled by default. 5. While disabled try clicking on the Allowed pickup locations dropdowns, you should not be able to. 6. In the 'Hold next available item', while enabled, you should be able to interact with the dropdowns. 7. Use the radio buttons to enable the 'Hold a specific item' fieldset. You should now be able to interact with the dropdowns. Created attachment 166744 [details] [review] Bug 36864: Add a font awesome icon to indicate enabled Created attachment 166768 [details] [review] Bug 36864: Add classes/CSS/fix markup on request.tt To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Place a hold 4. On reserve/request.pl the 'Hold a specific item' fieldset should be disabled by default. 5. While disabled try clicking on the Allowed pickup locations dropdowns, you should not be able to. 6. In the 'Hold next available item', while enabled, you should be able to interact with the dropdowns. 7. Use the radio buttons to enable the 'Hold a specific item' fieldset. You should now be able to interact with the dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 166769 [details] [review] Bug 36864: Add a font awesome icon to indicate enabled Signed-off-by: Owen Leonard <oleonard@myacpl.org> Very nice! Can we make the bug description a bit more descriptive please? :) Created attachment 166778 [details] [review] Bug 36864: Add classes/CSS/fix markup on request.tt To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Place a hold 4. On reserve/request.pl the 'Hold a specific item' fieldset should be disabled by default. 5. While disabled try clicking on the Allowed pickup locations dropdowns, you should not be able to. 6. In the 'Hold next available item', while enabled, you should be able to interact with the dropdowns. 7. Use the radio buttons to enable the 'Hold a specific item' fieldset. You should now be able to interact with the dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 166779 [details] [review] Bug 36864: Add a font awesome icon to indicate enabled Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice improvement, works as designed. Passing QA I think it's a visual improvement, but I feel people will still think they need to click into the rather small radio boxes instead of clicking on the label that is a much nicer click target. I wish we could improve on that in another bug maybe. Pushed for 24.05! Well done everyone, thank you! (In reply to Katrin Fischer from comment #10) > I think it's a visual improvement, but I feel people will still think they > need to click into the rather small radio boxes instead of clicking on the > label that is a much nicer click target. I wish we could improve on that in > another bug maybe. I agree. So I filed Bug 36899: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Depends on Bug 30579 not in 23.11.x |