Description
Jan Kissig
2024-05-16 07:08:53 UTC
Created attachment 166810 [details] [review] Bug 36877: Fix Patron card creator errors on editing layout, profile or template This patch fixes the unexpected behaviour when clicking on edit layout, edit profile or edit template in Patron card creator tool. Test plans: 1. edit layout: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. apply patch a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) Edit patron card layout form 20 shows up 2. edit template and profile: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=template or http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=profile b) click edit on an item in the table c) notice that the forms are empty apply patch and redo steps a) and b) to load the edit form Created attachment 166822 [details] [review] Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl Additionally removes fixme comments Created attachment 166823 [details] [review] Bug 36877: Fix Patron card creator errors on editing layout, profile or template This patch fixes the unexpected behaviour when clicking on edit layout, edit profile or edit template in Patron card creator tool. Test plans: 1. edit layout: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. apply patch a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) Edit patron card layout form 20 shows up 2. edit template and profile: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=template or http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=profile b) click edit on an item in the table c) notice that the forms are empty apply patch and redo steps a) and b) to load the edit form Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 166824 [details] [review] Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl Additionally removes fixme comments Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 166877 [details] [review] Bug 36877: Fix Patron card creator errors on editing layout, profile or template This patch fixes the unexpected behaviour when clicking on edit layout, edit profile or edit template in Patron card creator tool. Test plans: 1. edit layout: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. apply patch a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) Edit patron card layout form 20 shows up 2. edit template and profile: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=template or http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=profile b) click edit on an item in the table c) notice that the forms are empty apply patch and redo steps a) and b) to load the edit form Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 166878 [details] [review] Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl Additionally removes fixme comments Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> If the patron card create has this issue, do we expect similar problems in the label creator? Pushed for 24.05! Well done everyone, thank you! 23.11.x not impacted () |