Bug 36894

Summary:	Journal article request authors do not show in the ILL requests table
Product:	Koha	Reporter:	Matt Blenkinsop <matt.blenkinsop>
Component:	ILL	Assignee:	Matt Blenkinsop <matt.blenkinsop>
Status:	Pushed to oldstable ---	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	normal
Priority:	P5 - low	CC:	david, fridolin.somers, lucas, pedro.amorim, tomascohen
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes the table for interlibrary loan (ILL) requests so that it now displays authors for journal article requests.	Version(s) released in:	24.11.00,24.05.02,23.11.07
Circulation function:
Attachments:	Bug 36894: Display journal article ILL request author Bug 36894: Display journal article ILL request author Bug 36894: Display journal article ILL request author

Description Matt Blenkinsop 2024-05-17 10:25:09 UTC

The author field for journal article ILL requests is empty in the ILL table

Comment 1 Matt Blenkinsop 2024-05-17 10:28:36 UTC

Created attachment 166882 [details] [review]
Bug 36894: Display journal article ILL request author

This patch fixes the ILL request table to display authors for journal article request types

Test plan:
1) Create an ILL request with the type of Journal Article and add an author in the Article author field
2) Click on the List requests button to see the table
3) The Author field should be blank for the request you created
4) Apply patch
5) Hard refresh the browser to reload the javascript
6) The author field should now be visible

Comment 2 David Nind 2024-05-20 05:20:16 UTC

Created attachment 166925 [details] [review]
Bug 36894: Display journal article ILL request author

This patch fixes the ILL request table to display authors for journal article request types

Test plan:
1) Create an ILL request with the type of Journal Article and add an author in the Article author field
2) Click on the List requests button to see the table
3) The Author field should be blank for the request you created
4) Apply patch
5) Hard refresh the browser to reload the javascript
6) The author field should now be visible

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 David Nind 2024-05-20 05:22:39 UTC

Testing notes (using KTD):

1. I applied Bug 35570, as this includes the standard ILL request. Not sure if this should be a dependency.

Comment 4 Martin Renvoize (ashimema) 2024-06-07 09:52:25 UTC

Created attachment 167565 [details] [review]
Bug 36894: Display journal article ILL request author

This patch fixes the ILL request table to display authors for journal article request types

Test plan:
1) Create an ILL request with the type of Journal Article and add an author in the Article author field
2) Click on the List requests button to see the table
3) The Author field should be blank for the request you created
4) Apply patch
5) Hard refresh the browser to reload the javascript
6) The author field should now be visible

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 5 Martin Renvoize (ashimema) 2024-06-07 09:53:02 UTC

Trivial fix, thanks Matt.

Passing QA

Comment 6 Martin Renvoize (ashimema) 2024-06-11 07:14:19 UTC

Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant

Comment 7 Lucas Gass (lukeg) 2024-07-03 16:22:31 UTC

Backported to 24.05.x for upcoming 24.05.02

Comment 8 Fridolin Somers 2024-07-17 13:56:10 UTC

Pushed to 23.11.x for 23.11.07