Summary: | OAI set mapping form field maxlength should match table column sizes | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, lucas, m.de.rooy, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the OIA set mappings form so that you can't enter more characters than the maximum length for the input fields (Field (3), Subfield (1), and Value (80)). Previously, you could enter more characters - however, when you saved the form it generated an error.
|
Version(s) released in: |
24.11.00,24.05.04,23.11.10
|
Circulation function: | |||
Attachments: |
Bug 36907: Add maxlength to OAI set mapping form fields
Bug 36907: Add maxlength to OAI set mapping form fields Bug 36907: Add maxlength to OAI set mapping form fields |
Description
Owen Leonard
2024-05-21 10:38:44 UTC
Created attachment 166984 [details] [review] Bug 36907: Add maxlength to OAI set mapping form fields This patch adds a maxlength attribute to the field, subfield, and value fields in the OAI set mapping form. This helps prevent an error when the form data is too long for the database columns. Unrelated: The patch also adds quotes around two unquoted name attributes. To test, apply the patch and go to Administration -> OAI sets. - If necessary, create a new set. - Click Actions -> Define mappings. - Test that each form field is limited correctly: Field: 3 Subfield: 1 Value: 80 - Test that the form can be submitted successfully with the maximum number of characters in each field. Created attachment 167062 [details] [review] Bug 36907: Add maxlength to OAI set mapping form fields This patch adds a maxlength attribute to the field, subfield, and value fields in the OAI set mapping form. This helps prevent an error when the form data is too long for the database columns. Unrelated: The patch also adds quotes around two unquoted name attributes. To test, apply the patch and go to Administration -> OAI sets. - If necessary, create a new set. - Click Actions -> Define mappings. - Test that each form field is limited correctly: Field: 3 Subfield: 1 Value: 80 - Test that the form can be submitted successfully with the maximum number of characters in each field. Signed-off-by: David Nind <david@davidnind.com> Created attachment 170442 [details] [review] Bug 36907: Add maxlength to OAI set mapping form fields This patch adds a maxlength attribute to the field, subfield, and value fields in the OAI set mapping form. This helps prevent an error when the form data is too long for the database columns. Unrelated: The patch also adds quotes around two unquoted name attributes. To test, apply the patch and go to Administration -> OAI sets. - If necessary, create a new set. - Click Actions -> Define mappings. - Test that each form field is limited correctly: Field: 3 Subfield: 1 Value: 80 - Test that the form can be submitted successfully with the maximum number of characters in each field. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.04 Pushed to 23.11.x for 23.11.10 Not backporting to 23.05.x unless requested |